search

gluster / gluster-csi-driver

DEPRECATED: Gluster Container Storage Interface (CSI) driver
GNU Lesser General Public License v3.0
57 stars 30 forks source link

Dependency mess on kubernetes-csi/drivers and kubernetes-csi/csi-tests repos #131

Closed nigelbabu closed 5 years ago

nigelbabu commented 5 years ago

What I'm trying to do: Add 3 new dependencies so I can send a pull request for E2E framework

What's going wrong:

This is the specific error that we nee to solve.

master: Could not introduce github.com/kubernetes-csi/drivers@master, as it has a dependency on github.com/container-storage-interface/spec with constraint ^1.0.0, which has no overlap with existing constraint ^0.3.0 from (root)

Full error message

Solving failure: No versions of github.com/kubernetes-csi/drivers met constraints:
        v1.0.1: Could not introduce github.com/kubernetes-csi/drivers@v1.0.1, as it is not allowed by constraint master from project github.com/gluster/gluster-csi-driver.
        v1.0.0: Could not introduce github.com/kubernetes-csi/drivers@v1.0.0, as it is not allowed by constraint master from project github.com/gluster/gluster-csi-driver.
        v0.4.1: Could not introduce github.com/kubernetes-csi/drivers@v0.4.1, as it is not allowed by constraint master from project github.com/gluster/gluster-csi-driver.
        v0.4.0: Could not introduce github.com/kubernetes-csi/drivers@v0.4.0, as it is not allowed by constraint master from project github.com/gluster/gluster-csi-driver.
        v0.5.0-alpha.0: Could not introduce github.com/kubernetes-csi/drivers@v0.5.0-alpha.0, as it is not allowed by constraint master from project github.com/gluster/gluster-csi-driver.
        v0.4.0-rc.1: Could not introduce github.com/kubernetes-csi/drivers@v0.4.0-rc.1, as it is not allowed by constraint master from project github.com/gluster/gluster-csi-driver.
        master: Could not introduce github.com/kubernetes-csi/drivers@master, as it has a dependency on github.com/container-storage-interface/spec with constraint ^1.0.0, which has no overlap with existing constraint ^0.3.0 from (root)
        release-0.4: Could not introduce github.com/kubernetes-csi/drivers@release-0.4, as it is not allowed by constraint master from project github.com/gluster/gluster-csi-driver.
        release-1.0: Could not introduce github.com/kubernetes-csi/drivers@release-1.0, as it is not allowed by constraint master from project github.com/gluster/gluster-csi-driver.
        saad-ali-patch-1: Could not introduce github.com/kubernetes-csi/drivers@saad-ali-patch-1, as it is not allowed by constraint master from project github.com/gluster/gluster-csi-driver.
        saad-ali-patch-2: Could not introduce github.com/kubernetes-csi/drivers@saad-ali-patch-2, as it is not allowed by constraint master from project github.com/gluster/gluster-csi-driver.
        saad-ali-patch-2-1: Could not introduce github.com/kubernetes-csi/drivers@saad-ali-patch-2-1, as it is not allowed by constraint master from project github.com/gluster/gluster-csi-driver.
        v0.1.0: Could not introduce github.com/kubernetes-csi/drivers@v0.1.0, as it is not allowed by constraint master from project github.com/gluster/gluster-csi-driver.
nigelbabu commented 5 years ago

For now I'm moving the dependency on csi-test to v.0.3.5. We need to figure out which version of kubernetes-csi/drivers we want to pin to.

nigelbabu commented 5 years ago

The kubernetes-csi/drivers is the one we need to reconcile correctly as far as I can see. We currently lock to a38ee8520f16657511de3d1063ddbe06aeeee4c6 which is slightly older than v1.0.0. Should we jump over to v1.0.0?

Madhu-1 commented 5 years ago

we cannot jump to v1.0.0 until we get Kube 1.13 support in GCS.

nigelbabu commented 5 years ago

Alright, then. I'll keep the issue as blocked on Kube 1.13 support.

nigelbabu commented 5 years ago

Does it make sense to bind us to the exact revision we're bound to be Gopkg.lock then? That might help me push ahead and make some progress.

JohnStrunk commented 5 years ago

Looks like we should be able to advance to 1.13.1, pending PRs in gcs: gluster/gcs#98, gluster/gcs#77

Will those unblock your progress, @nigelbabu?

Madhu-1 commented 5 years ago

@nigelbabu we have updated CSI to v1.0.0

nigelbabu commented 5 years ago

Alright! Thank you!