search

gluster / gluster-csi-driver

DEPRECATED: Gluster Container Storage Interface (CSI) driver
GNU Lesser General Public License v3.0
57 stars 30 forks source link

E2e tests #136

Closed nigelbabu closed 1 year ago

nigelbabu commented 5 years ago

This is the initial patch for writing E2E tests with the k8s test framework.

Is there anything that requires special attention? I'd highly appreciate a review of the dependency changes and the general code layout for the tests.

The current plan is to write our own tests and consume the storage testsuite once kube 1.14 is out (when that code is stable enough to be consumed out of tree)

Waiting on the following

Once this is merged, I can work on infra to run this test.

centos-ci commented 5 years ago

Can one of the admins verify this patch?

nigelbabu commented 5 years ago

Currently running into an issue where I can't get the tests to compile because it pulls in a version of docker that's too old.

nigelbabu commented 5 years ago

I have confirmed that this works on an external GCS cluster setup on Digital Ocean using our deploy scripts.

nigelbabu commented 5 years ago

@JohnStrunk @Madhu-1 Do either of you want to take a stab at doing an initial review?

Madhu-1 commented 5 years ago

@JohnStrunk PTAL @nigelbabu please squash the commits.

nigelbabu commented 5 years ago

You could do a squash at the time of merge, which is what we do in other repos. Github can do "Sqash and Merge". That preserves the review history.

JohnStrunk commented 5 years ago

Seems reasonable.

BTW, we don't squash over here... the history is the history. Squashing messes up commit messages and invalidates gpg commit signatures.

amarts commented 5 years ago

Can this be taken to finish line? What more is pending other than a refresh?

joejulian commented 1 year ago

This is too old and will no longer be relevant as written. It'll be easier to create from scratch now.