search

gluster / gluster-csi-driver

DEPRECATED: Gluster Container Storage Interface (CSI) driver
GNU Lesser General Public License v3.0
57 stars 30 forks source link

Pass Args from one stage to another stage #143

Closed Madhu-1 closed 5 years ago

Madhu-1 commented 5 years ago

An ARG instruction goes out of scope at the end of the build stage where it was defined. To use an arg in multiple stages, each stage must include the ARG instruction. More info: https://docs.docker.com/engine/reference/builder/#scope Fixes: #98

Signed-off-by: Madhu Rajanna mrajanna@redhat.com

output:

Labels": {
                "Summary": "FUSE-based CSI driver for Gluster file access",
                "build-date": "2019-01-10T17:35:24.988988941Z",
                "io.k8s.description": "FUSE-based CSI driver for Gluster file access",
                "name": "glusterfs-csi-driver",
                "org.label-schema.schema-version": "= 1.0     org.label-schema.name=CentOS Base Image     org.label-schema.vendor=CentOS     org.label-schema.license=GPLv2     org.label-schema.build-date=20180531",
                "vcs-type": "git",
                "vcs-url": "https://github.com/gluster/gluster-csi-driver",
                "vendor": "gluster.org",
                "version": "1.0.0-pre.0.12.g4af48ca"
            }
JohnStrunk commented 5 years ago

I don't think this is the proper fix. We lost the version info because we switched to docker cloud for builds. Docker cloud doesn't currently run the ./build.sh script, it directly issues a docker build ... command. We need to either move to Travis for our container builds or override the build hook on cloud.docker.

My vote would be for using Travis because cloud.docker is slow and seems quite unreliable.

Work required is to add a deploy step to Travis to do the push, but we need to create a bot account w/ push rights to hub.docker... and I don't currently have a good solution for how to escrow that account's password (where should the gluster team keep it and who should have access?).