search

gluster / gluster-csi-driver

DEPRECATED: Gluster Container Storage Interface (CSI) driver
GNU Lesser General Public License v3.0
57 stars 30 forks source link

Automatically build virtblock driver #159

Closed JohnStrunk closed 5 years ago

JohnStrunk commented 5 years ago

Describe what this PR does This PR changes the build process to separate the building of the two CSI drivers. The name of the driver is now passed to the ./build.sh command to build the appropriate container.

Usage:

$ ./build.sh 
ERROR: No driver name specified.
Usage: build.sh <drivername>

Available drivers:
    glusterfs
    glustervirtblock

This also updates Travis to have separate jobs for each driver, and it adds a deploy step to the end of each job to push the containers to Quay. Since we are now building the containers in Travis, the resulting containers now have the proper version information. This is only a partial solution to #98 since the docker hub container is not fixed.

Is there anything that requires special attention? Do you have any questions? Did you do something clever?

Related issues: Fixes #157

centos-ci commented 5 years ago

Can one of the admins verify this patch?

JohnStrunk commented 5 years ago

With help from @nigelbabu I have updated the config on docker hub and Travis such that this should now push containers to both quay and docker into glusterfs-csi-driver and glustervirtblock-csi-driver.

We will need to deprecate gluster-csi-driver on docker hub and ensure all manifests are switched to glusterfs-csi-driver.

JohnStrunk commented 5 years ago

@Madhu-1 please review. This should unblock gluster/gcs#126.