search

gluster / gluster-csi-driver

DEPRECATED: Gluster Container Storage Interface (CSI) driver
GNU Lesser General Public License v3.0
56 stars 30 forks source link

Run yum update in final container #165

Closed JohnStrunk closed 5 years ago

JohnStrunk commented 5 years ago

Describe what this PR does This moves the final image of the containers to centos:7 and adds a yum update to the container build process in order to make sure we incorporate the latest security fixes.

Is there anything that requires special attention? no

Related issues:

centos-ci commented 5 years ago

Can one of the admins verify this patch?

nixpanic commented 5 years ago

On Mon, Feb 04, 2019 at 08:48:02AM -0800, Madhu Rajanna wrote:

Madhu-1 commented on this pull request.

Install dependencies

-RUN yum -y install centos-release-gluster && \ +RUN yum update -y && \

  • yum -y install centos-release-gluster && \

@kotreshhr why centos-release-gluster is added here?

The centos-release-gluster package provides the YUM repository that contains the glusterfs-fuse packages which is installed in one of the next yum commands.

JohnStrunk commented 5 years ago

The centos-release-gluster package provides the YUM repository that contains the glusterfs-fuse packages which is installed in one of the next yum commands.

@nixpanic Since we're manually adding the nightly repo, that means we can remove this. correct?

nixpanic commented 5 years ago

On Mon, Feb 04, 2019 at 05:06:04PM +0000, John Strunk wrote:

The centos-release-gluster package provides the YUM repository that contains the glusterfs-fuse packages which is installed in one of the next yum commands.

@nixpanic Since we're manually adding the nightly repo, that means we can remove this. correct?

There might be other dependencies that are not part of the nightly repositories. At the moment I do not think glusterfs-fuse depends on anything extra, but glusterfs-server definitely does. It is possible that in the future glusterfs-fuse will also require userspace-rcu, and the version of the library will need to match what was used for building (the CentOS Storage SIG one, not the older EPEL package).

So at the moment it is probably fine to drop it, but it might need to get added in the future again.

JohnStrunk commented 5 years ago

Thanks.

@Madhu-1 I think this is ready.