search

gluster / gluster-csi-driver

DEPRECATED: Gluster Container Storage Interface (CSI) driver
GNU Lesser General Public License v3.0
57 stars 30 forks source link

Make platform for SC parameter parsing. #84

Closed humblec closed 1 year ago

humblec commented 6 years ago

Describe what this PR does Provide some context for the reviewer

Is there anything that requires special attention? Do you have any questions? Did you do something clever?

Related issues: Mention any github issues relevant to this PR

humblec commented 6 years ago

@JohnStrunk @Madhu-1 PTAL. The goal of this patch is to place hold the way we can parse SC parameters.

humblec commented 6 years ago

@JohnStrunk PTAL .

humblec commented 6 years ago

@JohnStrunk any comments on this PR ? :)

JohnStrunk commented 6 years ago

Let's hold this until we get actual parameters to parse.

Also, validation is important. snapshotEnabled: yes would neither produce an error, nor the expected behavior... same is the case with a simple misspelling snapshotEnabled: treu.