search

gluster / gluster-kubernetes

GlusterFS Native Storage Service for Kubernetes
Apache License 2.0
875 stars 389 forks source link

added "--show-all" flag to stop hanging #525

Closed mrmarcsmith closed 5 years ago

mrmarcsmith commented 5 years ago

We were experiencing a hang because of a missing flag.

Environment Provider: Digital Ocean Machine: Ubuntu 16.04LTS K8s version: Client Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.0", GitCommit:"0ed33881dc4355495f623c6f22e7dd0b7632b7c0", GitTreeState:"clean", BuildDate:"2018-09-27T17:05:32Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.0", GitCommit:"0ed33881dc4355495f623c6f22e7dd0b7632b7c0", GitTreeState:"clean", BuildDate:"2018-09-27T16:55:41Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}

This change is Reviewable

centos-ci commented 5 years ago

Can one of the admins verify this patch?

phlogistonjohn commented 5 years ago

Interestingly, this option seems to have been removed as part of PR #502 remarking that the option has been deprecated. It also seems that someone commented on that PR saying that they hit an issue similar to the one you are describing. (CC: @SaravanaStorageNetwork )

Regardless of that, I recommend squashing your patches together to avoid seeing the intermediate debugging steps of set -x.

mrmarcsmith commented 5 years ago

@phlogistonjohn could an admin use the "squash and merge" button?

obnoxxx commented 5 years ago

@mrmarcsmith writes

@phlogistonjohn could an admin use the "squash and merge" button?

We actually disabled squash merges as it creates really bad commits. If you don't want to do the work, we can do the squashing and updating of this PR for you. But you are more than welcome to squash locally and force-push into your branch.

obnoxxx commented 5 years ago

I think this is actually the exact same patch as in PR #511.

obnoxxx commented 5 years ago

closing this as a duplicate of #511...