deploy: bind-mount /dev/disk into the glusterfs-server container

gluster / gluster-kubernetes

GlusterFS Native Storage Service for Kubernetes

Apache License 2.0

875 stars 389 forks source link

deploy: bind-mount /dev/disk into the glusterfs-server container #542

Closed nixpanic closed 5 years ago

nixpanic commented 5 years ago

Commit 2f1114a removed the bind-mount for /dev as this will be setup by the container runtime automatically. However it seems that /dev/disk is missing, prevending users to supply /dev/disk/by-id/* device names to Heketi.

This change adds /dev/disk as an additional bind-mount. CRI-O does prevent /dev to be bind-mounted, but subdirectories of /dev do not seem to be an issue.

Reported-by: Gal Ben Haim gbenhaim@redhat.com Signed-off-by: Niels de Vos ndevos@redhat.com

This change is

centos-ci commented 5 years ago

Can one of the admins verify this patch?

nixpanic commented 5 years ago

See-also: openshift/openshift-ansible#10793

jarrpa commented 5 years ago

LGTM