search

gluster / gluster-kubernetes

GlusterFS Native Storage Service for Kubernetes
Apache License 2.0
875 stars 389 forks source link

deploy: bind-mount /dev/mapper into the glusterfs-server container #544

Closed nixpanic closed 5 years ago

nixpanic commented 5 years ago

Commit 2f1114a removed the bind-mount for /dev as this will be setup by the container runtime automatically. However it seems that /dev/mapper is missing, prevending users to supply /dev/mapper/* device names to Heketi. It also seems possible that not all(?) LVM devices are available when a container starts.

This change adds /dev/mapper as an additional bind-mount. CRI-O does prevent /dev to be bind-mounted, but subdirectories of /dev do not seem to be an issue.

Fixes: #499 Signed-off-by: Niels de Vos ndevos@redhat.com

This change is Reviewable

centos-ci commented 5 years ago

Can one of the admins verify this patch?

jarrpa commented 5 years ago

LGTM!