search

gluster / gluster-kubernetes

GlusterFS Native Storage Service for Kubernetes
Apache License 2.0
875 stars 389 forks source link

Deploy GlusterFS by default, with a prompt #91

Open jarrpa opened 7 years ago

jarrpa commented 7 years ago

By default we should assume that we are meant to deploy the GlusterFS DaemonSet. However, we should prompt the user whether they want to deploy GlusterFS or not. This prompt should also include a small note as to the firewall requirements on the node for GlusterFS. The -g option should still be retained, with the slight modification that it simply assumes 'yes' and skips the prompt entirely.

raghavendra-talur commented 7 years ago

Wouldn't having a prompt mechanism break unattended setups?

jarrpa commented 7 years ago

Possibly, but we have a prompt right now for the case where the script detects both oc and kubectl on the same system. I'm not sure one would want or be able to make an unattended setup for production, and in most automation scenarios I can think of it'd be trivial to do something like echo n | gk-deploy. We could also create a --no-gluster flag to get around this.