glustercli peer list and peer status displays same output

PrasadDesala commented 5 years ago

Observed behavior

glustercli peer list and peer status displays same output.

[root@gluster-kube1-0 /]# glustercli peer list +--------------------------------------+-----------------+-------------------------------------+-------------------------------------+--------+-----+ | ID | NAME | CLIENT ADDRESSES | PEER ADDRESSES | ONLINE | PID | +--------------------------------------+-----------------+-------------------------------------+-------------------------------------+--------+-----+ | 50357e1b-5183-4125-b532-5bb7bd199e62 | gluster-kube2-0 | gluster-kube2-0.glusterd2.gcs:24007 | 10.233.64.5:24008 | yes | 26 | | | | | gluster-kube2-0.glusterd2.gcs:24008 | | | | a2a2df6f-0b19-4bab-b1dd-48278d464342 | gluster-kube3-0 | gluster-kube3-0.glusterd2.gcs:24007 | 10.233.66.6:24008 | yes | 25 | | | | | gluster-kube3-0.glusterd2.gcs:24008 | | | | ffe6e70d-b3e3-4f57-97b5-ff9c287f932d | gluster-kube1-0 | gluster-kube1-0.glusterd2.gcs:24007 | gluster-kube1-0.glusterd2.gcs:24008 | yes | 29 | +--------------------------------------+-----------------+-------------------------------------+-------------------------------------+--------+-----+ [root@gluster-kube1-0 /]# glustercli peer status +--------------------------------------+-----------------+-------------------------------------+-------------------------------------+--------+-----+ | ID | NAME | CLIENT ADDRESSES | PEER ADDRESSES | ONLINE | PID | +--------------------------------------+-----------------+-------------------------------------+-------------------------------------+--------+-----+ | 50357e1b-5183-4125-b532-5bb7bd199e62 | gluster-kube2-0 | gluster-kube2-0.glusterd2.gcs:24007 | 10.233.64.5:24008 | yes | 26 | | | | | gluster-kube2-0.glusterd2.gcs:24008 | | | | a2a2df6f-0b19-4bab-b1dd-48278d464342 | gluster-kube3-0 | gluster-kube3-0.glusterd2.gcs:24007 | 10.233.66.6:24008 | yes | 25 | | | | | gluster-kube3-0.glusterd2.gcs:24008 | | | | ffe6e70d-b3e3-4f57-97b5-ff9c287f932d | gluster-kube1-0 | gluster-kube1-0.glusterd2.gcs:24007 | gluster-kube1-0.glusterd2.gcs:24008 | yes | 29 | +--------------------------------------+-----------------+-------------------------------------+-------------------------------------+--------+-----+

Details on how to reproduce (minimal and precise)

1) Create a 3 node gcs setup using vagrant. 2) Run glustercli peer list and glustercli peer status commands.

Information about the environment:

Glusterd2 version used (e.g. v4.1.0 or master):
glusterd version: v6.0-dev.93.gitd4ca2cb
git SHA: d4ca2cb
go version: go1.11.2
go OS/arch: linux/amd64
Operating system used: CentOS 7.5
Glusterd2 compiled from sources, as a package (rpm/deb), or container: Container
Using External ETCD: (yes/no, if yes ETCD version): Yes version: 3.3.8
If container, which container image:
Using kubernetes, openshift, or direct install:
If kubernetes/openshift, is gluster running inside kubernetes/openshift or outside: Kubernetes

atinmu commented 5 years ago

@PrasadDesala So is the expectation that the peer list to just display the list of peers (UUID & Name) and nothing else?

PrasadDesala commented 5 years ago

@PrasadDesala So is the expectation that the peer list to just display the list of peers (UUID & Name) and nothing else?

either: 1) Yes, so that we have different outputs for peer list and peer status. 2) Since we are displaying the complete peer details and status in both the commands may be we can remove one (peer list) as any how status is displaying that information.

gluster / glusterd2