search

gluster / glusterfs

Gluster Filesystem : Build your distributed storage in minutes
https://www.gluster.org
GNU General Public License v2.0
4.51k stars 1.07k forks source link

[bug:1193929] GlusterFS can be improved #1000

Closed gluster-ant closed 2 years ago

gluster-ant commented 4 years ago

URL: https://bugzilla.redhat.com/1193929 Creator: jdarcy at redhat Time: 20150218T15:06:47

I hope this bug is never fixed.

The upstream patch process requires that each patch have an associated bug ID before it can be merged. However, there is no requirement that the bug contain any information or receive any kind of signoff before the patch can proceed. As a result, many of our developers have the habit of creating such "placeholder" bugs every time they want to make a change, even if it's just a random cleanup/idea and not an actual bug fix or requested/tracked feature request. Also, any patch with the dreaded "rfc" bug ID (which would be appropriate for such changes) is unlikely to be reviewed.

This bug exists to satisfy our process requirement, without the additional negatives of clogging up our triage/tracking processes and making it appear that the code has more bugs (which would be bad) when in fact a developer had more ideas (which is generally good).

gluster-ant commented 4 years ago

Time: 20180521T13:31:47 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20048 (api: cleanup headers) posted (#1) for review on master by Kaleb KEITHLEY

gluster-ant commented 4 years ago

Time: 20180523T15:29:11 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20073 (api: missing __THROW on pub function decls) posted (#1) for review on master by Kaleb KEITHLEY

gluster-ant commented 4 years ago

Time: 20180525T08:19:23 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20073 committed in master by "Amar Tumballi" amarts@redhat.com with a commit message- api: missing __THROW on pub function decls

missing __THROW on pub function decls needed for C++

Change-Id: Ia0ff09d311741e4cdc8ef171e07bbd56c24b9260 updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY kkeithle@redhat.com

gluster-ant commented 4 years ago

Time: 20180531T11:52:26 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20111 (libgfchangelog: Remove duplicate includedir definition for changelog.h) posted (#1) for review on master by Anoop C S

gluster-ant commented 4 years ago

Time: 20180601T04:40:18 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20111 committed in master by "Amar Tumballi" amarts@redhat.com with a commit message- libgfchangelog: Remove duplicate includedir definition for changelog.h

includedir for changelog.h is already defined in Makefile.am under libglusterfs/src since it was moved from xlators/features/changelog/lib/src. Therefore removing the duplicate definition.

Change-Id: Iaff2e02fca45715820caa35b41efc2f6b656203a updates: bz#1193929 Signed-off-by: Anoop C S anoopcs@redhat.com

gluster-ant commented 4 years ago

Time: 20180606T10:06:31 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20173 (MAINTAINERS: remove me from NFS maintainers) posted (#1) for review on master by Niels de Vos

gluster-ant commented 4 years ago

Time: 20180611T13:11:10 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20048 committed in master by "Amar Tumballi" amarts@redhat.com with a commit message- api: cleanup headers

fix inconsistent use in headers of: struct glfs and glfs_t struct glfs_fd and glfs_fd_t struct glfs_object and glfs_object_t

add typedefs to headers for various struct glfs_foos, and use them, e.g.: struct glfs_upcall and glfs_upcall_t

fix inconsistent type naming for 'enum glfs_lock_mode_t'. (All other enum decls are 'enum glfs_foo' not 'enum_glfs_foo_t'), and add typedefs for all enums, and use them.

style, replace tabs with spaces and follow return value style, i.e.: int pub_glfs_foo() instead of: int pub_glfs_foo()

Update copyright dates, substantial new work has been done since 2012

Change-Id: I0a9654486ea132efde7977b655799fb37887b1d5 Updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY kkeithle@redhat.com

gluster-ant commented 4 years ago

Time: 20180618T03:51:21 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20173 committed in master by "Amar Tumballi" amarts@redhat.com with a commit message- MAINTAINERS: remove me from NFS maintainers

My role at Red Hat changed a little and I do not have the time to look into gNFS anymore. If needed, I am still around to assist, but the initial contacts should be the active maintainers and peers.

Change-Id: I3cbae3c5cbd413abb6f95be238efc685c493c392 Updates: bz#1193929 Signed-off-by: Niels de Vos ndevos@redhat.com

gluster-ant commented 4 years ago

Time: 20180630T05:55:39 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20426 (xlators/playground: fix the template files with latest requirements) posted (#1) for review on master by Amar Tumballi

gluster-ant commented 4 years ago

Time: 20180702T11:23:59 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20437 (protocol/client: handle the fdctx_destroy properly with different versions) posted (#1) for review on master by Amar Tumballi

gluster-ant commented 4 years ago

Time: 20180703T06:06:02 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20446 (stack.h: fix the pass_through logic) posted (#1) for review on master by Amar Tumballi

gluster-ant commented 4 years ago

Time: 20180703T06:22:32 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20447 (checkpatch.pl: fix the perl warning) posted (#1) for review on master by Amar Tumballi

gluster-ant commented 4 years ago

Time: 20180703T19:12:55 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20446 committed in master by "Shyamsundar Ranganathan" srangana@redhat.com with a commit message- stack.h: fix the pass_through logic

while fixing the coverity issues, we made a minor mistake in the pass through logic in STACK_WIND macro.

Also, with this patch, made the code common to reduce possible future errors creeping in due to missing one place update.

updates: bz#1193929 Change-Id: I6fcfd156d63b0a7e6208819872e565eacf774150 Signed-off-by: Amar Tumballi amarts@redhat.com

gluster-ant commented 4 years ago

Time: 20180705T22:56:14 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20437 committed in master by "Shyamsundar Ranganathan" srangana@redhat.com with a commit message- protocol/client: handle the fdctx_destroy properly with different versions

while adding the new version of RPC, this part was not handled properly

Updates: bz#1193929 Change-Id: If4cc4c2db075221b9ed731bacb7cc035f7007c5b Signed-off-by: Amar Tumballi amarts@redhat.com

gluster-ant commented 4 years ago

Time: 20180706T08:13:29 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20447 committed in master by "Amar Tumballi" amarts@redhat.com with a commit message- checkpatch.pl: fix the perl warning

Used to get the below warning: Running coding guidelines check ... Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.30), passed through in regex; marked by <-- HERE in m/^(\+.*(?:do|\))){ <-- HERE / at ./build-aux/checkpatch.pl line 3102.

But as per the recommendation in perl document, we should escape the braces.

While this check should be removed from the codebase when we get the 'codingstandard' automated scripts, we can keep the code warning free at least till then.

updates: bz#1193929 Change-Id: I236a428174b5d16ca41baa03e96bc7aa26177b5b Signed-off-by: Amar Tumballi amarts@redhat.com

gluster-ant commented 4 years ago

Time: 20180706T10:56:38 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20472 (server: Rename xlator ID to 'server') posted (#1) for review on master by Prashanth Pai

gluster-ant commented 4 years ago

Time: 20180706T21:06:33 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20474 (Fix compile warnings) posted (#2) for review on master by Xavi Hernandez

gluster-ant commented 4 years ago

Time: 20180709T10:50:47 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20483 (Move time string formatting) posted (#2) for review on master by Yaniv Kaul

gluster-ant commented 4 years ago

Time: 20180710T16:19:31 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20493 (glusterd: log improvements on brick creation validation) posted (#1) for review on master by Atin Mukherjee

gluster-ant commented 4 years ago

Time: 20180710T19:39:06 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20474 committed in master by "Xavi Hernandez" xhernandez@redhat.com with a commit message- Fix compile warnings

This patch fixes compile warnings that appear with newer compilers. The solution applied is only to remove the warnings, but it doesn't always solve the problem in the best way. It assumes that the problem will never happen, as the previous code assumed.

Change-Id: I6e8470d6c2e2dbd3bd7d324b5fd2f92ffdc3d6ec updates: bz#1193929 Signed-off-by: Xavi Hernandez xhernandez@redhat.com

gluster-ant commented 4 years ago

Time: 20180711T04:09:04 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20472 committed in master by "Amar Tumballi" amarts@redhat.com with a commit message- server: Set ssl-allow option in options table and rename ID

This change explicitly adds 'ssl-allow' options to the server xlator's options table so that glusterd2 can see it as a settable option. This change also marks 'auth.allow' and 'auth.reject' options as a settable.

Glusterd2 doesn't maintain a separate volume options table. Glusterd2 dynamically loads shared objects of xlators to read their option table and other information. Glusterd2 reads 'xlator_api_t' if available. If that's not available, it falls back to reading just the options table directly.

In glusterd2, volume set operations are performed by users on keys of the format .. Glusterd2 uses xlator name set in 'xlator_api_t.identifier'. If that's not present it will use the shared object's file name as xlator name. Hence, it is important for 'xlator_api_t.identifier' to be set properly, and in this case, the proper value is "server". This name shall be used by users as prefix while setting volume options implemented in server xlator. The name will also be used in volfile.

A user in glusterd2 can authorize a client over TLS as follows:

$ glustercli volume set server.ssl-allow [,]

gd2 References: https://github.com/gluster/glusterd2/issues/971 https://github.com/gluster/glusterd2/issues/214 https://github.com/gluster/glusterd2/pull/967

Updates: bz#1193929 Change-Id: I59ef58acb8d51917e6365a83be03e79ae7c5ad17 Signed-off-by: Prashanth Pai ppai@redhat.com

gluster-ant commented 4 years ago

Time: 20180711T04:14:35 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20493 committed in master by "Amar Tumballi" amarts@redhat.com with a commit message- glusterd: log improvements on brick creation validation

Added few log entries in glusterd_is_brickpath_available ().

Change-Id: I8b758578f9db90d2974f7c79126c50ad3a001d71 Updates: bz#1193929 Signed-off-by: Atin Mukherjee amukherj@redhat.com

gluster-ant commented 4 years ago

Time: 20180713T08:25:43 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20503 (tests/geo-rep: increase the timeout) posted (#1) for review on master by Amar Tumballi

gluster-ant commented 4 years ago

Time: 20180713T10:08:22 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20503 committed in master by "Amar Tumballi" amarts@redhat.com with a commit message- tests/geo-rep: increase the timeout

since some time, geo-rep tests were in the border of 180-190 seconds to complete. As actual test timeout is 200 seconds by default, giving these tests some buffer time to complete properly.

updates: bz#1193929 Change-Id: I9f501a02b52585dff7d0473824bdbb229e124278 Signed-off-by: Amar Tumballi amarts@redhat.com

gluster-ant commented 4 years ago

Time: 20180715T09:23:42 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20512 (glusterd-quota.c: fix coverity warning (BAD_COMPARE)) posted (#1) for review on master by Yaniv Kaul

gluster-ant commented 4 years ago

Time: 20180716T08:29:31 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20515 (glusterd-store: fix coverity warning) posted (#1) for review on master by Yaniv Kaul

gluster-ant commented 4 years ago

Time: 20180716T14:25:17 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20522 (All: run codespell on the code and fix issues.) posted (#1) for review on master by Yaniv Kaul

gluster-ant commented 4 years ago

Time: 20180717T05:42:22 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20515 committed in master by "Amar Tumballi" amarts@redhat.com with a commit message- glusterd-store: fix coverity warning

The same variable 'len' was used both in the macros and the functions. (Introduced as part of commit 6dc5dfef819cad69d6d4b4c1c305efa74236ad84 ?)

Change-Id: If434999d6470067f8a1e501c8e132561e8cd81ef updates: bz#1193929 Signed-off-by: Yaniv Kaul ykaul@redhat.com

gluster-ant commented 4 years ago

Time: 20180717T05:42:49 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20483 committed in master by "Amar Tumballi" amarts@redhat.com with a commit message- tier: Move time string formatting

There is no need to format the time, unless ret is true.

I don't think there's a reason to allocate memory for those struct and char array unless we are formatting either (But I'm not sure what the code convention is - are we ok with 'local' variable declarations?)

Only compile-tested.

Change-Id: I9feb09871943764bd76bdfc9ac6ca506f329aac1 updates: bz#1193929 Signed-off-by: Yaniv Kaul ykaul@redhat.com

gluster-ant commented 4 years ago

Time: 20180718T11:05:57 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20524 committed in master by "Shyamsundar Ranganathan" srangana@redhat.com with a commit message- build/core: location of xattr.h

starting with libattr-devel-2.4.48-1 in Fedora 28 <attr/xattr.h> has been removed from the package.

On Fedora, RHEL/CentOS, and SUSE, the glibc-headers package has provided a near identical file, <sys/xattr.h>, in all the releases that we care about.

On Debian, libc6-dev provides <sys/xattr.h> all the way back to 8/Jessie and presumably all Ubuntu derivatives since then.

Note that on Debian the sys headers are installed in /usr/include/$DEB_HOST_GNU_TYPE/sys/...

Change-Id: Id07c4b225bdaa6556bd54772604e75b8f346fb60 updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY kkeithle@redhat.com

gluster-ant commented 4 years ago

Time: 20180719T06:12:02 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20533 (gcc warnings: fix the few remaining warnings) posted (#1) for review on master by Amar Tumballi

gluster-ant commented 4 years ago

Time: 20180719T12:40:30 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20538 (doc: Add details around xlator classifications) posted (#1) for review on master by Shyamsundar Ranganathan

gluster-ant commented 4 years ago

Time: 20180720T05:11:12 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20540 (coding-standard: add points on structure padding) posted (#1) for review on master by Amar Tumballi

gluster-ant commented 4 years ago

Time: 20180720T05:12:15 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20541 (doc: add details on how the commit msg should be) posted (#1) for review on master by Amar Tumballi

gluster-ant commented 4 years ago

Time: 20180720T05:13:18 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20542 (doc: add coding-standard and commit-msg link in README) posted (#1) for review on master by Amar Tumballi

gluster-ant commented 4 years ago

Time: 20180720T05:38:07 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20543 (doc: keep just one copy of a coredump analysis) posted (#1) for review on master by Amar Tumballi

gluster-ant commented 4 years ago

Time: 20180720T09:27:35 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20545 (glusterd: fix gcc7 warnings) posted (#1) for review on master by Amar Tumballi

gluster-ant commented 4 years ago

Time: 20180721T20:11:31 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20548 (contrib/xxhash: update to latest xxHash (0.6.5)) posted (#1) for review on master by Yaniv Kaul

gluster-ant commented 4 years ago

Time: 20180722T14:40:52 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20522 committed in master by "Amar Tumballi" amarts@redhat.com with a commit message- All: run codespell on the code and fix issues.

Please review, it's not always just the comments that were fixed. I've had to revert of course all calls to creat() that were changed to create() ...

Only compile-tested!

Change-Id: I7d02e82d9766e272a7fd9cc68e51901d69e5aab5 updates: bz#1193929 Signed-off-by: Yaniv Kaul ykaul@redhat.com

gluster-ant commented 4 years ago

Time: 20180724T18:43:41 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20562 (georep: fix hard-coded paths in gsyncd.conf.in) posted (#1) for review on master by Kaleb KEITHLEY

gluster-ant commented 4 years ago

Time: 20180725T18:22:26 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20562 committed in master by "Shyamsundar Ranganathan" srangana@redhat.com with a commit message- georep: fix hard-coded paths in gsyncd.conf.in

This is part of the reason why we use autoconf (i.e. configure). For an ordinary clone+autogen.sh+configure SBIN_DIR is /usr/local/sbin; for an rpm or dpkg build it will be /usr/sbin.

I wonder how many more are lurking in our sources? /usr/libexec is one that frequently bites us on Debian and Ubuntu, which don't have /usr/libexec. (But it's all Linux, right?)

See https://bugzilla.redhat.com/show_bug.cgi?id=1601532

Reported-by: lohmaier+rhbz@gmail.com Change-Id: I6523894416cc06236ea1f99529efd36e957bd98e updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY kkeithle@redhat.com

gluster-ant commented 4 years ago

Time: 20180726T17:39:52 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20572 (stack: Reduce stack usage for local variables to store tmpfile names) posted (#1) for review on master by Shyamsundar Ranganathan

gluster-ant commented 4 years ago

Time: 20180727T09:07:00 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20572 committed in master by "Amar Tumballi" amarts@redhat.com with a commit message- stack: Reduce stack usage for local variables to store tmpfile names

This patch moves stack based PATH_MAX allocations for tmpfile names, to heap allocated names instead. Reducing the impact on stack space used and accruing benefits thereof.

Change-Id: I646d9cb091018de6768b3523902788fa2ba14d96 Updates: bz#1193929 Signed-off-by: ShyamsundarR srangana@redhat.com

gluster-ant commented 4 years ago

Time: 20180731T00:21:34 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20591 (contrib: Remove gf_mkostemp copied from GLibC) posted (#1) for review on master by Shyamsundar Ranganathan

gluster-ant commented 4 years ago

Time: 20180801T18:41:48 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20543 committed in master by "Shyamsundar Ranganathan" srangana@redhat.com with a commit message- doc: keep just one copy of a coredump analysis

Keeping two copies of the files means, one would be out-of-date soon, and users would always be confused about which one is the source of truth.

Updates: bz#1193929 Change-Id: I568149732fdb9d282ccd583640eee9b9056963fd Signed-off-by: Amar Tumballi amarts@redhat.com

gluster-ant commented 4 years ago

Time: 20180802T05:15:01 bugzilla-bot at gluster.org commented: COMMIT: https://review.gluster.org/20540 committed in master by "Amar Tumballi" amarts@redhat.com with a commit message- coding-standard: add points on structure padding

This is a recommendation for users, and reviewers can take a point from this.

Updates: bz#1193929 Change-Id: Idcd778e42a886fd79b549da4927149a07573a20b Signed-off-by: Amar Tumballi amarts@redhat.com

gluster-ant commented 4 years ago

Time: 20180802T17:43:10 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20624 (All: remove memset() before sprintf()) posted (#1) for review on master by Yaniv Kaul

gluster-ant commented 4 years ago

Time: 20180803T12:25:05 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20633 (coding-standard: memset before snprintf) posted (#1) for review on master by Susant Palai

gluster-ant commented 4 years ago

Time: 20180810T10:23:09 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20700 (glusterd: remove the unused databuf in rebalance structure) posted (#1) for review on master by Amar Tumballi

gluster-ant commented 4 years ago

Time: 20180810T10:32:59 bugzilla-bot at gluster.org commented: REVIEW: https://review.gluster.org/20702 (bd: remove the translator from build) posted (#1) for review on master by Amar Tumballi