search

gluster / glusterfs

Gluster Filesystem : Build your distributed storage in minutes
https://www.gluster.org
GNU General Public License v2.0
4.65k stars 1.08k forks source link

CID 1490756: Control flow issues (DEADCODE) in dht_unlock_entrylk() #3657

Open mykaul opened 2 years ago

mykaul commented 2 years ago

** CID 1490756: Control flow issues (DEADCODE) /xlators/cluster/dht/src/dht-lock.c: 408 in dht_unlock_entrylk()

*** CID 1490756: Control flow issues (DEADCODE)

/xlators/cluster/dht/src/dht-lock.c: 408 in dht_unlock_entrylk()
402     done:
403         if (lock_frame)
404             dht_lock_stack_destroy(lock_frame, DHT_ENTRYLK);
405     
406         /* no locks acquired, invoke entrylk_cbk */
407         if (ret == 0)
>>>     CID 1490756:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "(*entrylk_cbk)(frame, NULL,...".
408             entrylk_cbk(frame, NULL, frame->this, 0, 0, NULL);
409     
410         return ret;
411     }
412     
413     int32_t
stale[bot] commented 1 year ago

Thank you for your contributions. Noticed that this issue is not having any activity in last ~6 months! We are marking this issue as stale because it has not had recent activity. It will be closed in 2 weeks if no one responds with a comment here.