core: The brick process is getting crash during upcall event

[mohit84]

A brick process may crash while it try to send upcall notification to the client and client disconnect is being process.

Solution: Avoid upcall event notification to the client if disconnect is being process for the same client.

Fixes: #4255 Change-Id: I80478d7f4a038b04a10fb21a1290b4309e9fe4dd

[mohit84]

/run regression

[gluster-ant]

CLANG-FORMAT FAILURE: Before merging the patch, this diff needs to be considered for passing clang-format

index 08d6712f3..0a696e062 100644
--- a/xlators/protocol/server/src/server.c
+++ b/xlators/protocol/server/src/server.c
@@ -306,8 +306,8 @@ get_auth_types(dict_t *this, char *key, data_t *value, void *data)
             ret = dict_set_dynptr(auth_dict, tmp, NULL, 0);
             if (ret < 0) {
                 gf_msg_debug("server", 0,
-                            "failed to "
-                            "dict_set_dynptr");
+                             "failed to "
+                             "dict_set_dynptr");
             }
         }
     }
@@ -1469,9 +1469,9 @@ server_process_event_upcall(xlator_t *this, void *data)
             if (!client || strcmp(client->client_uid, client_uid))
                 continue;

-           /* Avoid upcall notification to client if disconnect is in
-              progress
-            */
+            /* Avoid upcall notification to client if disconnect is in
+               progress
+             */
             if (GF_ATOMIC_GET(xprt->disconnect_progress))
                 continue;

[gluster-ant]

1 test(s) failed ./tests/basic/quota-nfs.t

0 test(s) generated core

2 test(s) needed retry ./tests/basic/afr/gfid-mismatch-resolution-with-cli.t ./tests/basic/quota-nfs.t https://build.gluster.org/job/gh_centos7-regression/3356/

[mohit84]

/run regression