gluster / glusterfs

Gluster Filesystem : Build your distributed storage in minutes
https://www.gluster.org
GNU General Public License v2.0
4.51k stars 1.07k forks source link

prevent gnfs IO Errors on smaller files #4334

Open erikja opened 1 month ago

erikja commented 1 month ago

In certain situations, smaller files will report I/O errors when accessed from NFS using Gluster NFS. With our settings, files up to 170M could report this in some cases. It was not a consistent failure.

Disbling the NFS performance I/O cache seemed to work around the instances of the problem observed for non-sharded volumes.

Research showed that gluster NFS is relying on an errno return value of EINVAL to detect EOF and set is_eof. However, in some paths this value was not retained or was reset to zero.

This change passes the errno along so it can be used by gluster NFS. We found the issue in the shard xlator and the io-cache xlator.

gluster-ant commented 1 month ago

Can one of the admins verify this patch?

gluster-ant commented 1 month ago

Can one of the admins verify this patch?

gluster-ant commented 1 month ago

Can one of the admins verify this patch?

erikja commented 1 month ago

See

https://github.com/gluster/glusterfs/pull/4322