gluster / glusterfs

Gluster Filesystem : Build your distributed storage in minutes
https://www.gluster.org
GNU General Public License v2.0
4.51k stars 1.07k forks source link

super micro improvemens in posix translator. #4338

Open jkroonza opened 4 weeks ago

jkroonza commented 4 weeks ago

These were spotted trying to better understand the readdir code. They are trivial and frankly, will save only a handful of cycles.

gluster-ant commented 4 weeks ago

Can one of the admins verify this patch?

gluster-ant commented 4 weeks ago

Can one of the admins verify this patch?

gluster-ant commented 4 weeks ago

Can one of the admins verify this patch?

gluster-ant commented 4 weeks ago

CLANG-FORMAT FAILURE: Before merging the patch, this diff needs to be considered for passing clang-format

index 4b523328b..d1cddaf8a 100644
--- a/xlators/storage/posix/src/posix-inode-fd-ops.c
+++ b/xlators/storage/posix/src/posix-inode-fd-ops.c
@@ -6032,10 +6032,7 @@ posix_readdirp(call_frame_t *frame, xlator_t *this, fd_t *fd, size_t size,
         if (op_ret >= 0) {
             op_ret = 0;

-            list_for_each_entry(entry, &entries.list, list)
-            {
-                op_ret++;
-            }
+            list_for_each_entry(entry, &entries.list, list) { op_ret++; }
         }

         STACK_UNWIND_STRICT(readdirp, frame, op_ret, op_errno, &entries, NULL);