search

gluster / project-infrastructure

Issues related to GlusterFs infrastructure components.
0 stars 0 forks source link

Requesting access to gluster/gluster-containers #165

Open black-dragon74 opened 2 years ago

black-dragon74 commented 2 years ago

Hi team!

I would be maintaining the gluster-containers repo as it has been in inactive development from quite some time and some OSS projects that depend on it (minikube for instance) require the latest image.

Can someone please allow me access to merge and review PRs on the said repo?

Regards

mscherer commented 2 years ago

ok done.

black-dragon74 commented 2 years ago

Thank you. Do you have any idea about whom I can reach out to for Gluster DockerHub credentials?

mscherer commented 2 years ago

That one ( https://hub.docker.com/u/gluster ) ? No idea, but I can ask around.

black-dragon74 commented 2 years ago

That one ( https://hub.docker.com/u/gluster ) ?

Yes.

No idea, but I can ask around.

That'd be of great help.

Regards

akhal3d96 commented 2 years ago

Hello @black-dragon74

I'd like to volunteer with you in maintaining the repo and docker image.

amarts commented 2 years ago

@gluster/gluster-containers any help here..

@black-dragon74 @akhal3d96 so what is the plan? How do you plan to revive this, and how is this planned to be used? ie, is there a Dockerfile sample you have? can you send the PR to gluster-containers repo?

nixpanic commented 2 years ago

Unfortunately I do not have permissions to the Docker registry. Hopefully @humblec can help here, or al least share the credentials so that volunteers from the Gluster community can setup CI for publishing updated images (broken since a Travis CI change?).

spowelljr commented 2 years ago

Sorry to butt in here, minikube is looking to have a GitHub maintainer for all our addons, any addons missing a maintainer would have a warning displayed to the user when the addon is enabled.

A maintainer would just be a point of contact we would reach out to if something goes wrong, ie. the current missing Docker Hub repo issue, stops working with a k8s upgrade, or critical CVE is discovered in the addon.

Would either/both of you @black-dragon74 & @akhal3d96 be interested in this?

Thanks

black-dragon74 commented 2 years ago

@spowelljr I'd love that.

Regards

black-dragon74 commented 2 years ago

How do you plan to revive this

The plan is to actively monitor any PRs and promptly address any compatibility/security issues that might arise. Basically, the development of it would be active. It doesn't require much to be done TBH and I can manage it in my time.

Is there a Dockerfile sample you have?

Yes, I have not pushed CentOS update as of now (still a few things to address) but there is a PR open for Fedora 36, here.

can you send the PR to gluster-containers repo?

1 done, more to follow.

Regards

black-dragon74 commented 2 years ago

Hopefully @humblec can help here, or al least share the credentials so that volunteers from the Gluster community can setup CI for publishing updated images (broken since a Travis CI change?).

That'd be really helpful. I only have access to the gluster-container GH repo.

Regards

black-dragon74 commented 2 years ago

Hello @black-dragon74

I'd like to volunteer with you in maintaining the repo and docker image.

Thank you so much for volunteering. Will surely ping you if anything needs to be done.

Regards

mscherer commented 2 years ago

I would suggest to look at Github actions and github package registry rather than travis and docker hub, less accounts to manage for us.

black-dragon74 commented 2 years ago

I would suggest to look at Github actions and github package registry rather than travis and docker hub, less accounts to manage for us.

If @nixpanic is okay with this, I can get it done today. I also +1 this idea. Would be more seamless.

Goodnight for me :)

Regards

nixpanic commented 2 years ago

If @nixpanic is okay with this, I can get it done today. I also +1 this idea. Would be more seamless.

Sure! That is relatively straight forward to setup, using the container-image from an other registry just needs minor changes by users (who have very old images now anyway). Once setup, make sure to update the location in minikube too.

black-dragon74 commented 2 years ago

Hi team!

Container for both the flavors (CentOS and Fedora) are ready to go. The CentOS container refers to the latest tag.

I have also setup the CI/CD along with linter tests for Dockerfile and Shell scripts. We are using GHCR as @mscherer suggested.

I have opened a PR for the integration with GH actions.

So all the work is done, all that's left is sweet sweet PR merges.

You can see a demo run of the GH action here. It publishes the (demo but functional) packages here

I need someone who has organization rights to please create an access token and add it to gluster-containers repo's secrets. The name should be GLFS_SKEY.

Everything will work flawlessly then.

/cc: @nixpanic

Regards

nixpanic commented 2 years ago

Great work! That is a really good improvement already.