search

gluster / python-gluster-mgmt-client

Python bindings for gluster
GNU General Public License v3.0
5 stars 3 forks source link

Add bindings for georep APIs #15

Closed devyanikota closed 6 years ago

devyanikota commented 6 years ago

Signed-off-by: Devyani Kota devyanikota@gmail.com

aravindavk commented 6 years ago

Glusterd2 issue to get Geo-rep sessions list https://github.com/gluster/glusterd2/issues/950

devyanikota commented 6 years ago

@aravindavk, I have worked on the suggested changes, and @Madhu-1, I have added the checks for authentication of valid clients. Please review, Thank you.

devyanikota commented 6 years ago

@sac @aravindavk @Madhu-1 hi o/ I have added the georep tests as well. Please check, thanks.

devyanikota commented 6 years ago

@Madhu-1 I have handled the re-establishment of the client session after a successful georep connection is established. Removed the creation and deletion operations of directories(gd2 handles the same), and I have addressed the rest of the review comments on status checks. Apart from this, added a TODO to track the task to organize tests using fixtures, which I can handle in the upcoming PR. Please let me know if I need to take care of anything else. @sac @Madhu-1 please review the same. Thank you.

devyanikota commented 6 years ago

PR Status update: The tests added here for the georep APIs pass for the successful creation of georep sessions. The tests for the rest of the georep operations when tested with the latest gd2 build are failing on the server end. I'll have to check on the gd2 end, for these raft errors. The gd2 binary version am using is the latest one, taken from the GD2 releases page[1].

[root@rhs31-b gd2_rpm]# ./glusterd2 --version
glusterd version: v4.1.0-0

[1] https://github.com/gluster/glusterd2/releases

If we can take this forward, I can work on the rest of the tests in the upcoming PR. Since this is a really huge chunk of code and it's kinda too late to separate them now. @sac @Madhu-1 what do you guys think? Thanks.

sac commented 6 years ago

@devyanikota can you please abandon this PR and separate the API and the tests? Once the code-autogeneration is stable, we will use the tests and can replace the API with autogenerated code.

devyanikota commented 6 years ago

@sac yes, I'll go ahead and do that. Thanks.

devyanikota commented 6 years ago

Closing this PR, in favour of PR #19 and #20 @sac ^^^