glut23 / webvtt-py

Read, write, convert and segment WebVTT caption files in Python.
MIT License
194 stars 56 forks source link

Match MS Teams timestamp format #43

Closed nathan-gilbert closed 2 years ago

nathan-gilbert commented 2 years ago

Hi,

Microsoft Teams produces a timestamp format that appears to meet the WebVtt standard but the currently existing regular expression does not match against it.

The Team's timestamp format: 0:0:13.540 --> 0:0:17.850

This PR attempts to expand the regular expression to match this case.

nathan-gilbert commented 2 years ago

Actually, it is Teams that is out of spec. I'm closing this as it's really a Team's problem.

apetresc commented 2 years ago

This should be resolved in #45. I disagree that we shouldn't fix it just because it's a Teams problem. If we're being pragmatic, Microsoft will never fix this and being compatible on our end costs us nothing in terms of accuracy or performance.