Drag & drop of multiple tags divided by unselected tags resulting in freeze

galantra commented 5 years ago

Which add-on is affected?

BetterTag – current version from Patreon

Prerequisite checklist

[x] In case of a bug: Have you tried restarting Anki?
[x] Are you running the latest version of the add-on? Have you redownloaded the add-on from AnkiWeb to make sure?
[x] Did you check the add-on description on AnkiWeb for known issues?
[x] Did you perform a cursory search through existing issue reports?

What is the problem/feature you would like to see fixed/implemented?

drag multiple tags divided by unselected tags

How can we reproduce the problem?

Open browser
select several tags by Ctrl+leftclick
make sure there re unselected tags between the selected tags
drag the selected tags onto an unselected tag

Expected behavior: Selected tags will be subtags of the tag onto which you dragged them

Actual behavior: browser does not display notes and can only be closed by task manager, not alt+f4 Once, the rest of anki (I had the reviewer open) also freezed. The other times, I could access the main screen as well as review cards.

Reproducible?: yes

Version information

Anki

Version 2.1.15 (6661ba8a) Qt 5.12.1 PyQt 5.11.3

System

Operating system: Windows
Version: 10

glutanimate commented 5 years ago

Thanks for the detailed report! I can confirm the issue here on Anki 2.1. 2.0 seems to be unaffected. I am also fairly certain that this worked fine when I did my last round of release testing, so I assume this regression must have been introduced with Qt 5.12 (which Anki switched to around 2.1.10).

Marking this as a severe regression and will try to find a fix asap.

glutanimate commented 5 years ago

Just created a dedicated repo to host the bug tracking for BetterTags. Moving the issue there.

glutanimate commented 4 years ago

This should be fixed with BetterTags v1.0.0. Thanks again for taking the time to report this, and sorry it took so long to address!

glutanimate / bettertags-public