No tag suggestions with BetterTags

arkhandir commented 4 years ago

Problem description

BetterTags (1.0.3) causes me problems with the setting of keywords. When editing notes, no tag suggestions are made, regardless of the settings in the BetterTags options. Occasionally (!), after deactivating/activating (Enable tag completer modifications) and restarting, tag setting works briefly as expected. I use macOS (10.14.6).

Checklist

[x] I've restarted Anki to see if it helps
[x] I've verified that I use the latest version of the add-on by redownloading it from AnkiWeb
[x] I've verified that I use the latest version of Anki by checking at https://apps.ankiweb.net#download
[i] I've tried to disable other add-ons to see if there are any interactions present
[x] My issue disappears when I hold shift while starting Anki.
[x] I've checked if anyone else reported this problem before by looking through the issue reports. I also checked to see if there is a section about known issues in the add-on description, documentation, or README.

If you are using Anki 2.1

Anki 2.1.23 (de9543ff) Python 3.8.0 Qt 5.13.1 PyQt 5.14.1
Platform: Mac 10.14.6
Flags: frz=True ao=True sv=1
Add-ons, last update check: 2020-03-20 16:39:15

===Add-ons (active)===
(add-on provided name [Add-on folder, installed at, version, is config changed])
Add Table ['1237621971', 2020-01-07T23:31, 'None', mod]
Advanced Browser ['874215009', 2020-02-20T23:39, 'None', '']
Auto Markdown ['1030875226', 2019-09-13T21:21, 'None', '']
BetterTags ['bettertags', 2020-01-28T21:30, 'None', mod]
Cloze Overlapper ['cloze_overlapper', 2019-02-01T13:37, 'None', '']
Ignore accents in browser search ['1924690148', 2019-09-23T22:02, 'None', '']
Image Occlusion Enhanced for Anki 21 alpha ['1374772155', 2019-09-20T23:35, 'None', '']
Mini Format Pack ['295889520', 2019-09-26T18:02, 'None', '']
Progress Graphs and Stats for Learned and Matured Cards ['266436365', 2019-09-21T21:55, 'None', '']
Review Heatmap ['review_heatmap', 2018-10-28T23:06, 'None', '']

===IDs of active AnkiWeb add-ons===
1030875226 1237621971 1374772155 1924690148 266436365 295889520 874215009

===Add-ons (inactive)===
(add-on provided name [Add-on folder, installed at, version, is config changed])
Automatic Basic to Cloze ['2105427255', 2019-09-20T23:34, 'None', '']
Batch Editing ['291119185', 2019-09-12T21:37, 'None', '']
Customize Sidebar ['1988760596', 2020-01-15T22:01, 'None', mod]
Enhance main window ['877182321', 2020-02-16T03:51, 'None', '']
Incremental Reading v4103 ['935264945', 2019-09-17T23:40, 'None', '']
PDF Glossary Exporter ['pdf_glossary', 2019-08-19T14:35, 'None', '']
Pop-up Dictionary beta ['153625306', 2019-09-25T22:52, 'None', '']
Resize images in editor ['1103084694', 2020-03-20T09:03, 'None', mod]
Search and Replace Tags ['138501288', 2019-09-12T12:35, 'None', '']
True Retention ['613684242', 2019-09-12T00:00, 'None', '']

glutanimate commented 4 years ago

Thanks for the report, arkhan, much appreciated!

So the fact that tag suggestions are being affected regardless of whether the "tag completer modifications" setting is enabled in BetterTags or not would point to something weird going on.

To dive into the technical side of things: With "tag completer modifications" disabled (and after restarting Anki), BetterTags won't touch that part of Anki's code, so barring some incredibly weird side effects it's almost impossible for the add-on to affect the tag completer's behavior.

Still, it doesn't seem like you have any other add-ons installed that could obviously interact with the completer.

So my request for now would be to try to completely disable BetterTags for a day of using Anki or so, and see if you are still experiencing issues with the tag completer. To bridge the time you could install Hierarchical Tags 2 which does not provide any editing capabilities, but should at least allow you to continue navigating your tag hierarchies in the browser. (the add-on also does not touch the tag completer code at all, so it's a good control test)

On my end I will try and see if I can reproduce the bug somehow by replicating your system & add-on setup. Will let you know if I find anything.

Thanks again for taking the time to help with fixing this!

arkhandir commented 4 years ago

There was a misunderstanding: by "regardless of the settings in the BetterTags options" I meant the state of the two checkboxes under "Enable tag completer modifications", not "Enable tag completer modifications" itself. Thanks for your time.

glutanimate / bettertags-public