glutanimate / highlight-search-results

Highlight Search Results in the Browser add-on for Anki
https://ankiweb.net/shared/info/225180905
Other
13 stars 5 forks source link

[Highlight Search Results in the Browser] Search by flags highlights the enum (1-4) in the browser fields #4

Closed kanjieater closed 4 years ago

kanjieater commented 5 years ago

Which add-on is affected?

Highlight Search Results in the Browser

Prerequisite checklist

[ Please enter an [ x ] character to confirm the points below: ]

What is the problem/feature you would like to see fixed/implemented?

When doing a search that contains flags, you use numbers (flag:4 would search all your blue flags). The number of the flag is highlighted in the browser. When the flag:[0-9] params are used, it should not highlight the number of the flag. [ Please be as specific as possible. Provide screenshots if you think they can help. ]

How can we reproduce the problem?

Flag something blue. Search for flag:4. You will find your blue card. If you have a field with a value of 4 in it, it will be highlighted.

[ What were you doing when the problem occurred? ] image

Expected behavior: [ What you expected to happen ] No highlighting should happen for flags, since it is an enum representation, and not a contentful search. Actual behavior: [ What actually happened ] The enum digit is highlighted in content. Reproducible?: [ Can you reliably reproduce the issue by following the steps above? ] yes.

Version information

Anki

[ Please head to HelpAbout Anki and Paste the version string here, e.g.: ]

[ Version 2.0.14 ] [ Qt 5.12.1 PyQt 5.11.3 ]

System

glutanimate commented 5 years ago

Thanks for the detailed report! Unfortunately there is no way for me to address this, as Qt's native search feature does not allow for adding any type of exclusions to the content that's searched through. However, I will keep monitoring the qt docs and attempt to fix this as soon as it's technically feasible.

glutanimate commented 4 years ago

Hi! Thanks again for the report. Please disregard my last reply, I confused the description with a different problem case (where field names would be highlighted).

A fix for this is now live in master and will land as part of the next release.