[browser_search_highlight_results] results not highlighted - quoted, trailing space

ijgnd commented 5 years ago

originally reported on ankiweb on 2019-05-22 by user dashakol

Prerequisite checklist

[ Please enter an [ x ] character to confirm the points below: ]

[x] In case of a bug: Have you tried restarting Anki?
[x] Are you running the latest version of the add-on? Have you redownloaded the add-on from AnkiWeb to make sure?
[x] Did you check the add-on description on AnkiWeb for known issues?
[x] Did you perform a cursory search through existing issue reports?

What is the problem/feature you would like to see fixed/implemented?

Anki 2.1.13 with browser_search_highlight_results (downloaded today) and no other add-ons in a new profile:

when a string is quoted only the last word is highlighted

highlight_wo

if there's a trailing slash there's no highlighting: highlight_with

Reproducible?: [ Can you reliably reproduce the issue by following the steps above? ]

Yes

Version information

Anki

Anki 2.1.13 (3ba55990) Python 3.6.7 Qt 5.12.1 PyQt 5.11.3
Platform: Windows 10
Flags: frz=True ao=True sv=1

Add-ons:

Highlight Search Results in the Browser

System

Operating system: Win
Version: 10Pro 1809 64bit

glutanimate commented 5 years ago

Thanks for bringing this to my attention and taking the time to compile this excellent bug report. I can confirm this behavior here and will look into a solution.

glutanimate commented 5 years ago

Seems like GitHub needs to work on its natural language processing...

In any case, would you mind giving the latest master build a try? I pushed a few changes which should hopefully address the issue (and also improve a few other tidbits here and there).

PS: It can be very time-consuming to sift through the flood of (usually incomplete) support requests across Reddit, Tenderapp, AnkiWeb, emails, etc. So the work you've put towards repackaging this issue report and adding all of the relevant info is highly appreciated. Thank you!

ijgnd commented 5 years ago

did a brief test on 2.0 and 2.1 and it seems to work as intended (given the limitations you have listed as todo). That was a really quick fix!

glutanimate commented 5 years ago

Great, thanks!

glutanimate / highlight-search-results