glutanimate / image-occlusion-enhanced

Anki add-on that transforms images into cloze tests
https://ankiweb.net/shared/info/1374772155
Other
397 stars 41 forks source link

Incremental Reading add-on causing masks to be offset #141

Open An-png opened 4 years ago

An-png commented 4 years ago

EDIT: This only happens with the incremental reading addon active. See this issue

The image occulsion mask is offset, revealing parts of the answer. This doesn't happen in the editor, it only happens when reviewing card. If you resize the window, you can reveal even more of the answer when you shouldn't be able to. Here is a video demonstrating the problem:

imageocclusion_misplaced_mask.zip

Am using Anki 2.1.22 and the latest version of image occlusion enhanced alpha for anki 2.1 (bcos I pressed check for new updates and it said no new updates available).

This does not seem to be a problem for AnkiDroid Screenshot_20200326-200041_AnkiDroid

Debug info:

Anki 2.1.22 (0ecc189a) Python 3.8.1 Qt 5.14.1 PyQt 5.14.1
Platform: Linux
Flags: frz=True ao=True sv=1
Add-ons, last update check: 2020-03-25 20:58:12

===Add-ons (active)===
(add-on provided name [Add-on folder, installed at, version, is config changed])
Batch Editing ['291119185', 2019-06-02T19:47, 'None', '']
Blitzkrieg II - Advanced Browser Sidebar BETA7 ['564851917', 2020-02-25T18:57, 'None', '']
Cloze Hide All ['1709973686', 2019-11-27T07:50, 'None', '']
Cloze Overlapper ['cloze_overlapper', 2019-02-01T12:37, 'None', '']
Color Confirmation ['1084228676', 2020-03-14T12:13, 'None', '']
CrowdAnki JSON exportimport Edit history Collaborate on deck creation ['1788670778', 2020-01-14T03:52, 'None', '']
Edit LaTeX build process ['937148547', 2018-10-12T22:33, 'None', '']
Fill the blanks - Multiple typecloze support ['1933645497', 2020-03-14T01:20, 'None', '']
Frozen Fields ['516643804', 2020-03-01T04:12, 'None', '']
Hierarchical Tags 2  Anki 2117 support ['594329229', 2020-01-29T15:05, 'None', '']
Image Occlusion Enhanced for Anki 21 alpha ['1374772155', 2020-02-16T11:46, 'None', '']
Improved Quizlet to Anki 21 Importer ['538351043', 2020-02-25T00:00, 'None', '']
Incremental Reading v4103 ['935264945', 2019-04-21T13:54, 'None', '']
Kitten Rewards Gamification ['1627107763', 2018-11-10T08:14, 'None', '']
LPCG LyricsPoetry Cloze Generator ['2084557901', 2019-08-30T19:40, 'None', '']
Large and Colorful Buttons ['1829090218', 2018-10-02T18:41, 'None', '']
Mini Format Pack ['295889520', 2020-02-16T11:45, 'None', '']
Progress Graphs and Stats for Learned and Matured Cards ['266436365', 2019-06-13T06:36, 'None', '']
Puppy Reinforcement ['puppy_reinforcement', 2020-03-02T19:09, 'None', mod]
ReviewHeatmap ['723520343', 2020-02-16T11:46, 'None', '']
Search and Replace Tags ['138501288', 2017-08-29T19:58, 'None', '']

===IDs of active AnkiWeb add-ons===
1084228676 1374772155 138501288 1627107763 1709973686 1788670778 1829090218 1933645497 2084557901 266436365 291119185 295889520 516643804 538351043 564851917 594329229 723520343 935264945 937148547

===Add-ons (inactive)===
(add-on provided name [Add-on folder, installed at, version, is config changed])

OS: Linux Mint 19

An-png commented 4 years ago

Please help!! this is making image occlusion unuseable on anki desktop. One fix was to change the position of the #io-wrapper to "absolute", but this means the header and footer comes above the image. If you cange the position of #io-original to absolute, this also solves the problem but the toggle mask button is misplaced and goes partially underneath the image.

An-png commented 4 years ago

This is also a problem with new cards!! I tried moving all the cards to a new note type, uninstalling image occlusion, deleting the note type, reinstalling and moving all the cards back to the image occlusion note type and it didn't work!!!

An-png commented 4 years ago

Changing Collection to a fresh new one works, but I can't get it to work for my main collection...

glutanimate commented 4 years ago

The cards being rendered correctly on a different collection points to an issue with the card templates or other add-ons interfering with things.

Please try changing the name of your "Image Occlusion Enhanced" to something random temporarily. Then restart Anki and click on the IO button. This should prompt the add-on to regenerate the default note type and card templates. With the note type and templates back to the defaults, could you check if you're still experiencing the issue? If so, then please try disabling all add-on aside from IO next.

If the issue still persists, please send me an .apkg export of some of the affected cards at ankiglutanimate@gmail.com and I'll take a look.

An-png commented 4 years ago

Thanks for the suggestions, glutanimate! Seems like it is an addon issue, because disabling every single addon works! (However, with all the addons enabled the issue didn't persist with another profile.)

I singled out the addon (by disabled others addons and seeing if it affected the issue) and it seems like incremental reading, which for me doesn't work at all. The developer doesn't seem to be responing to issues, which is a shame. You have commited fixing a issue where incremental reading conflicts with addons. Maybe this is related to that

glutanimate commented 4 years ago

Thanks for investigating this @An-png. Unfortunately at the moment I do not have the time to look into implementing a workaround. And with incremental reading not having been updated in a while (e.g. the patch I submitted in 09/2019 still isn't live on AnkiWeb yet), I don't have high hopes that I could do much to fix this on IR's end. It also seems like a lot of users have issues running IR on Anki 2.1.20+ in the first place.

I will leave this issue open in case development on IR picks up again, or this becomes a frequent enough issue for other users to implement a workaround on IO's side (which, depending on what exactly causes this interference, might not actually be possible, though).