glutanimate / mini-format-pack

Extends Anki 2.1 with a number of additional text formatting buttons
https://ankiweb.net/shared/info/295889520
Other
49 stars 13 forks source link

changing insertHorizontalRule hotkey description #19

Closed tandcode closed 3 years ago

tandcode commented 4 years ago

Description

The "ctrl+shift+alt+_" hotkey does't work with underscore, but the "ctrl+shift+alt+-" works well.

Checklist:

glutanimate commented 3 years ago

Hey @tandcode, Thanks for the contribution and my apologies for taking so long to review this.

Hmm, what keyboard layout are you using, if I may ask? I just tested the add-on again, and it seems like both variants (ctrl+shift+alt+_ and ctrl+shift+alt+-) work for me. However, I am using a German keyboard layout, and on there - and _ are bound on the same key, with Shift+<key> yielding _.

My concern with merging this PR is that I don't know what effect this will have on other keyboard layouts, and since is the first report to the effect that the binding is not working, I'm afraid it might break for other users.

glutanimate commented 3 years ago

Coming back to this: I assume that finding shortcuts that work for all layouts will never 100% work, and right now I am not sure which one between the current assignment and the suggested assignment is supported more widely. So for now I'm closing this issue, but will try to re-evaluate the defaults in the future.