glutanimate / popup-dictionary

Pop-up Dictionary Add-on for Anki
https://ankiweb.net/shared/info/153625306
Other
77 stars 15 forks source link

Only shows results from current deck #4

Closed grahamkwaj closed 6 years ago

grahamkwaj commented 6 years ago

Prerequisite checklist

What is the problem/feature you would like to see fixed/implemented?

[Be as specific as possible. Provide screenshots if you think they can help.]

Didn't work at all until I disabled Night mode, It now seems to work, however: When I search a term it seems to only bring up the results in my current deck, not my entire collection. I.E. I know I have a card in another deck with "hydroxyapatite" but searching brings up no results, however, If I highlight the word "disease" only results from my current deck are shown. Just an example, I have tried and confirmed this with multiple different cards.

How can we reproduce the problem?

[What were you doing when the problem occurred?]

Expected behavior: [What you expected to happen] Search entire collecting for all matching cards

Actual behavior: [What actually happened] only showed results from current deck

Reproducible?: [Can you reliably reproduce the issue by following the steps above?]

Version information

Anki

[Please head to HelpAbout Anki and Paste the version string here, e.g.:]

[Version 2.1]

System

grahamkwaj commented 6 years ago

Your reddit comment helped me out. I'll copy to here and close the issue:

"The add-on searches the current deck by default. You can change that behavior in the settings by setting snippetsLimitToCurrentDeck to false. In order to change the settings, either use Anki 2.1's built-in config dialog, or manually open and edit the meta.json file found in the popup_dictionary folder after running the add-on for the first time. More config values may be found here: https://github.com/glutanimate/popup-dictionary/blob/master/src/popup_dictionary/config.md"

grahamkwaj commented 6 years ago

It would still be nice for it to work with night mode though, I imagine that is a problem with night mode and not on your end.