Closed Stark-X closed 3 years ago
Stark-X
commented
4 years ago It's broken, because of the Anki remove a methdo deckDueList, which is used here.
https://github.com/glutanimate/anki-addons-misc/blob/f1e6693b0fd02184d60458a465d0902ca1cda147/src/reviewer_progress_bar/reviewer_progress_bar.py#L328
Reference Link: https://github.com/ankitects/anki/commit/769bf04f753f6d415501d9230a200955fb5881a5
millett
commented
4 years ago Hey @glutanimate check out this PR https://github.com/ankitects/anki/commit/769bf04f753f6d415501d9230a200955fb5881a5
millett
commented
4 years ago The progress bar add-ons appear to be the only active users of it; they can switch their old code from iterating over the list to simply locating the selected deck in deckDueTree(), as its counts should summarize all the child decks.
millett
commented
4 years ago ope i see the bot figured that out for you already 😅
glutanimate
commented
3 years ago This is coming (very) late, but I appreciate the reports and discussion, guys. A fix for Anki versions 2.1.28 and up is now merged into the current development branch (thanks to @liuzikai) and will be part of the next release.
glutanimate
commented
3 years ago I initially thought about keeping this issue open to keep track of the upcoming release, but I think that would be a bit confusing, considering that the fix is already merged.
So what I did was create a meta issue here as an overview of what's left to do for the upcoming v2.0.0 release: #29
Hence closing this issue for now.
Which add-on is affected?
Progress Bar
Prerequisite checklist
What is the problem/feature you would like to see fixed/implemented?
make it work again on the Anki 2.1.26+
How can we reproduce the problem?
Upgrade Anki to version 2.1.26+
Expected behavior: Enabled, and work normally
Actual behavior: Disabled because of version
Reproducible?: Yes
Version information
Anki
Version 2.1.28 (7d8818f8) Python 3.8.0 Qt 5.15.0 PyQt 5.15.0
System