[Puppy Reinforcement]: Cards counted toward reviews multiple times while editing

SpongebobSquamirez commented 5 years ago

In the Puppy Reinforcement addon, cards seem to be counted even if they are failed, or if you edit the card while reviewing, which I do frequently for new cards; and I think maybe even if they are just viewed. This can massively balloon the review count and show "reinforcement" at the wrong time.

Prerequisite checklist

[X] In case of a bug: Have you tried restarting Anki?
[X] Are you running the latest version of the add-on? Have you redownloaded the add-on from AnkiWeb to make sure?
[X] Did you check the add-on description on AnkiWeb for known issues?
[X] Did you perform a cursory search through existing issue reports?

What is the problem/feature you would like to see fixed/implemented?

I would like the counter in the Puppy Reinforcement addon to either 1) only increment when passing a card, or 2) only increment when passing or failing. Specifically, it should not increment just by seeing a card or by editing a card/switching to the browser/editor and returning; and should undo when you undo a card.

The current behavior can easily balloon the rate at which I see "rewards" to 2-4x what it should be (which, sure, I can fix easily myself by adjusting the addon parameters), but more importantly, I very often see the rewards after either simply editing a card or failing it. This issue was also reported last year on AnkiWeb by someone:

"Has a rather flawed counting system. When I decided to try this out, I was rusty (and there were new cards, too), so I kept missing the same handful of cards several times. However, it kept counting up, turning more into a "You failed this many times" counter.

If it's going to do something like this, it could at least try to be encouraging, instead of rubbing in the fact that I'm rusty.

I may try this again later, when I'm more up to speed. Even then, I think I'll tweak its behavior."

How can we reproduce the problem?

Try failing cards
Try editing cards directly or in the browser in the middle of reviews
Maybe also starting to review a card and then exiting the deck (but I'm not sure this one increases the counter).
Pass a card and then undo the pass

Expected behavior: Only when passing a card, increase the counter (and if undoing, undo). Avoid incrementing when switching from the browser/editor back to the card.

Actual behavior: Pretty much any interaction with a card seems to increase the counter

Reproducible?: Yes

Version information

Anki

[ Please head to Help → About Anki and Paste the version string here, e.g.: ] [ Version 2.0.47 ] [ Qt 4.8.1 PyQt 4.9.1 ]

2.0 something. Will update ASAP.

System

Operating system: Windows
Version: 10

glutanimate commented 5 years ago

Thanks for the detailed report! I can confirm the issue here, and this is definitely not the intended behavior of the add-on. Added to my to-do list to fix in the upcoming release.

glutanimate commented 5 years ago

Also, I recently created a dedicated repo for puppy reinforcement, so I'm moving the issue there.

SpongebobSquamirez commented 5 years ago

Thanks! Btw I have both Anki 2.0 and 2.1.14 or whatever the latest release is now (transitioning to 2.1), and I have this addon in both, so I hope this fix will also be implemented in 2.1.

glutanimate commented 5 years ago

2.1 is now the development focus for all of my add-ons, so no worries there! (it's the other way around, rather: I will likely start dropping support for 2.0 in most of my add-ons soon, as maintaining both release lines has become very tedious and user migration is now at a point where it's viable to move forward)

SpongebobSquamirez commented 5 years ago

Any news on this? Still makes my reviews pretty painful (yeah, I know I can just disable it).

glutanimate / puppy-reinforcement