glutanimate / puppy-reinforcement

Puppy Reinforcement add-on for Anki
https://ankiweb.net/shared/info/1722658993
Other
15 stars 9 forks source link

Reopen #10: Count should undo when you undo a card #18

Open SpongebobSquamirez opened 4 years ago

SpongebobSquamirez commented 4 years ago

This is actually an old bug, described in #10 (i.e I'm essentially petitioning to reopen #10 here, which is why I haven't filled out the issue form in detail)

It seems that this problem hasn't been resolved. In my original issue, I noted that the count "should undo when you undo a card." Although the fix that caused interactions with the card to not cause the card count to balloon has been fixed, the increment count is not decreased when undoing (e.g. with ctrl+z).

It's simple to reproduce this bug. Just continually pass a card and undo your pass. Even though you'll only have gone through a single card, your count will continually increase. I.e. just open a deck and press "space, space, ctrl+z" continually until you see an image pop up.

This bug often causes my card count to be 50-100% higher than the actual count. I use the timer plugin, which often causes Anki to lag for a couple seconds if I pass the card too close to the end of the timer (and psychologically, I often do so), resulting in a failure even if I did press pass a couple seconds before time was up. This means I have to subsequently undo and immediately pass that card I accidentally failed. But this results in the overall effect of the card count incrementing by 2 for such instances.

Anyway, I'm sure it's a quick fix, but it's very problematic for me personally, so I hope this bug can be remedied and the count issue be finally fixed.

I also know that some people don't like the fact that the count still increases regardless of whether you passed or failed the card, but since I don't think failure is even a good word to apply to needing to see a card again (since it's only natural for you to forget things, i.e. it's not your fault), I think that is fine as it is, personally.