glutanimate / syntax-highlighting

A fork of Tiago Barroso's Syntax Highlighting add-on with support for Anki 2.1
https://ankiweb.net/shared/info/1463041493
Other
108 stars 27 forks source link

added JSX formatting to JavaScript #19

Closed lukkea closed 1 month ago

lukkea commented 4 years ago

Description

This comment by @hbergren prompted me to pull this repo into syntax-highlighting. With a couple of tweeks it's working. I have added a "JSX" option to the menu. I also wondered if there should also be a "React" option that does the same as this, but that seemed unnecessary to me so I didn't do that.

I didn't follow the contributing guidelines in my previous pull request and just realised I hadn't created a dedicated branch to hold the changes (I just used a repo I wasn't going to use for anything else).

I have now done it as Glutanimate requested.

Checklist:

Please replace the space inside the brackets with an x and fill out the ellipses if the following items apply:

Digital-Coder commented 3 years ago

it is unfortunate that they didnt merge this pull request and I was lucky to find it here because I really need JSX support. Thanks a lot @lukkea !

danielvelara commented 2 years ago

Hi @lukkea, is there a way we could also create a PR for adding TSX support?

lukkea commented 2 years ago

Hi @lukkea, is there a way we could also create a PR for adding TSX support?

Yes - tsx could be added the list, but this PR is around eighteen months old and, along with a couple of others I did in @glutanimate's repos, it doesn't appear to have been seen by any maintainers so I expect it might not be the best way you could spend an hour or so...