search

glutengo / angular-mgl-timeline

Timeline component for Angular
MIT License
67 stars 33 forks source link

Allow header styling #21

Closed cribbstechnologies closed 5 years ago

cribbstechnologies commented 5 years ago

Currently the click event is on the mgl-timeline-entry-card-header element. If you restyle the header to appear differently then the click event fires if the user clicks on the background of the card header and there's no way to prevent it. The click event now looks for either the dot or the header element in the event path of the click before toggling the item open. In the below image clicks where the arrow point do not toggle the item open.

image

Click events in the header and dot can still be overridden to stop event bubbling and prevent the content from toggling open.

The demo without the styling changes still functions as before

cribbstechnologies commented 5 years ago

Any chance we could get this PR merged and a new release created?

glutengo commented 5 years ago

Merged and released in Version 0.3.0

cribbstechnologies commented 5 years ago

Awesome! Thanks for prioritizing it

On Fri, Jan 11, 2019 at 5:12 PM markus notifications@github.com wrote:

Merged and released in Version 0.3.0

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/glutengo/angular-mgl-timeline/pull/21#issuecomment-453673591, or mute the thread https://github.com/notifications/unsubscribe-auth/ABjyfWRgFN2JHByqyqtNWv4QwjvDgoBXks5vCQw9gaJpZM4Zz7Pc .