search

glutengo / angular-mgl-timeline

Timeline component for Angular
MIT License
67 stars 33 forks source link

[Usage] 'Color' attribute is confusing #5

Closed guillaumegarcia13 closed 6 years ago

guillaumegarcia13 commented 6 years ago

The 'color' attribute on mgl-timeline-entry-dot is actually confusing. One may expect to fill a rgb or a hexadecimal value whereas the content is set as a class on the element.

If it actually is a class, why not simply use existing class or ngClass instead?

glutengo commented 6 years ago

I agree. I am only using it as a class because this way I can use the colors from the angular material theme (primary, accent). I‘ll consider changing it to something like mat-color or simple ngClass support. Again, this can happen in two weeks time as I am currently on vacation. You can however make a proposal via a pull request in the meantime, if you want to. Thank you

glutengo commented 6 years ago

Attribute name was changed to class. Will be released on NPM in v 0.2.0 soon