search

glutengo / angular-mgl-timeline

Timeline component for Angular
MIT License
67 stars 33 forks source link

Theme typography scss build error #90

Open mikkelalstrup opened 2 years ago

mikkelalstrup commented 2 years ago

Hi there, I am getting this error when trying to apply the material theme with @include mgl.timeline-theme($your-theme):

SassError: isn't a valid CSS value. image

In commit dce728fb81ad3946119f6146d2786e196a83c5c2 line 12 in src/timeline/timeline.theme.scss, was changed to mat.font-family((font-family: $typographyConfig));

However it works if I change it locally to the following mat.font-family($typographyConfig);

Version: 1.0.0 - Angular 14

glutengo commented 2 years ago

Hi @mikkelalstrup

I have just tried this locally and on StackBlitz (I updated the example to use the new 1.0.0 version ) and it seems to work OK there. Could you please check for differences between your setup and the StackBlitz Demo setup? Maybe a difference in the @angular/material version?

Thanks.

mikkelalstrup commented 2 years ago

Hi again. Thank you for looking at it @glutengo.

I managed to reproduce the error by including a custom typography in $mgl-app-theme: mat.define-light-theme. https://stackblitz.com/edit/angular-mgl-timeline-kac5sc?file=src/theme.scss

Please see the angular documentation here. I inserted the angular documentation example into the example that you linked above.

Looking forward to hearing from you.