search

glutinum-org / cli

https://glutinum.net/
59 stars 6 forks source link

Display a notification to the user if they are trying to report a bug with an URL which is going to be too big #151

Open NatElkins opened 4 days ago

NatElkins commented 4 days ago

Steps to repro:

  1. Navigate to https://glutinum.net/
  2. Paste in the index.d.ts file for vscode. It's about 20K lines.

Click Report issue. On FF nothing happens, on Chrome the following happens:

image
MangelMaxime commented 3 days ago

This is probably a limitation coming from the Browsers because the URL is too long. There is also a limitation on Github side on how big the URL can be to create an issue.

I also prefer issues to be trim down to the problem instead of having a big file to manually filter myself.

For all these reason, I don't think there is something to do about this issue.

NatElkins commented 3 days ago

Gotcha, that makes sense. I do think a size limit that is displayed to the user might be useful. When it didn't work I was scratching my head for a bit.

MangelMaxime commented 3 days ago

It should indeed be possible to add a toast to notify that the URL is too big.

I will first test by using Github max length because to me this is the URL length that we care the most about. And hopefully, it will also cover the browsers too