gluxon / phpwolf

The popular Werewolf game (variant of Mafia) powered by a PHP IRC bot
GNU General Public License v3.0
12 stars 7 forks source link

Send JOIN after identifying #61

Open TheLlamaLover opened 10 years ago

TheLlamaLover commented 10 years ago

For UnrealIRCd and InspIRCd servers, the JOIN command is sent before identifying to NickServ. The process shouldn't be: : NOTICE AUTH :* Looking up your hostname... : NOTICE AUTH :* Found your hostname (cached) PING :<random numbers/letters> : 451 JOIN :You have not registered

gluxon commented 10 years ago

So just to be clear. JOIN should be sent after the NickServ ident request? And phpwolf is currently sending JOIN before?

TheLlamaLover commented 10 years ago

Yes, apparently. At least on UnrealIRCd servers. Anope on UnrealIRCd uses the channel mode +r to designate registered channels

gluxon commented 10 years ago

Thanks for letting me know. I'll try to get to it but it probably won't be soon.

WindowsUser commented 10 years ago

"You have not registered" means that the client has not completed its registration with the IRC server itself, not the services; the server will not accept client commands until it is satisfied with letting the user register. This means that you should wait a bit after sending the registration commands or implement SASL support.

arshem commented 10 years ago

I actually got around this by creating a command named "joinchannel" and having it JOIN #channelname

gluxon commented 10 years ago

@arshem or anyone else. Feel free to send in pull requests. If any of you would be willing to help maintain the project, I'd be more than happy to add you as a committer.

arshem commented 10 years ago

I forked it and started mine through there =) I love this script. It saved me a lot of time from building it from scratch =D