search

gluxon / wireguard-uapi-rs

MIT License
31 stars 9 forks source link

Cargo: update derive_builder #16

Closed returntoreality closed 2 years ago

returntoreality commented 2 years ago

This updates the derive_builder dependency to it's current version. Note that this is a non backwards compatible change and thus probably needs a major version according to semver. I want to update neli soon as well, but that is more work.

codecov[bot] commented 2 years ago

Codecov Report

Merging #16 (f1a8492) into develop (84c77c9) will decrease coverage by 0.28%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #16      +/-   ##
===========================================
- Coverage    70.74%   70.46%   -0.29%     
===========================================
  Files           25       25              
  Lines         1494     1500       +6     
===========================================
  Hits          1057     1057              
- Misses         437      443       +6
Impacted Files Coverage Δ
src/linux/err/parse_device_error.rs 0.00% <0.00%> (ø)
src/xplatform/parser/parse.rs 71.22% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 84c77c9...f1a8492. Read the comment docs.

gluxon commented 2 years ago

Note that this is a non backwards compatible change and thus probably needs a major version according to semver.

I appreciate this note and agree. I was looking into whether we could alias the error type from derive_builder, but it does seem to be hard-coded as a String on 0.7.1. It's probably best to just bump the minimum version requirement on derive_builder like you did here.

I want to update neli soon as well, but that is more work.

I'm expecting a future version of this library to remove the neli dependency. It's a bit larger-scoped than this library needs. In its place would be a macro that declaratively derives netlink structs.

Appreciate the PR. I'm going to merge this in but will wait on other changes before cutting a 3.0 release. Let me know if a 3.0 alpha version would be appreciated though.