search

gluxon / wireguard-uapi-rs

MIT License
32 stars 10 forks source link

Update to Neli 0.5.3 #21

Closed ernestask closed 1 year ago

ernestask commented 2 years ago

I thought I would get to 0.6.1 incrementally, because the breaking changes in 0.5.x are still closer to the existing code.

gluxon commented 2 years ago

Hey @ernestask, I appreciate the work here a lot, but I'm actually a bit unsure about neli long-term.

I'm investigating a Netlink library more like serde that allows you to automatically derive Netlink serialization/deserialization on structs and enums.

gluxon commented 2 years ago

I thought I would get to 0.6.1 incrementally, because the breaking changes in 0.5.x are still closer to the existing code.

Not opposed to bumping neli if you're strongly opinionated though. Moving incrementally sounds like the right strategy. 🙂

ernestask commented 2 years ago

Oh, I didn’t know that. Any reason in particular you want to move away from Neli?

I’m really only trying to breathe some more life into the library, since it’s used at my day job, so no strong attachments to anything.

gluxon commented 2 years ago

Oh, I didn’t know that. Any reason in particular you want to move away from Neli?

Neli is a great library with an awesome maintainer, but its API design requires imperative/manual parsing of Netlink structures. I'm hoping for a Netlink Rust library that allows Netlink data structures to be more decoratively defined. This library would then just expose definitions of Wireguard netlink structures.

Analogizing to web technologies, ideally there's a library similar to OpenRPC in the Netlink Rust world, and this library simply declares schemas.

I’m really only trying to breathe some more life into the library, since it’s used at my day job, so no strong attachments to anything.

I certainly appreciate it. Thank you!

ernestask commented 2 years ago

Okay, there were some bugs, but it’s fully functional now, from what I saw.

gluxon commented 1 year ago

Hey @ernestask, I apologize for the late review. I probably demotivated some of the work here unintentionally. Would it be appreciated if I make some of the suggestions in the PRs and merge this in?

ernestask commented 1 year ago

Hey, sorry for dropping the ball. I read the emails and promptly forgot to get back to you.

If it’s no big issue, yeah, you can take over. I’ll reply wherever I remember something.

gluxon commented 1 year ago

Cool. Thanks for the responses. I'll do a few followup commits and merge this soon.

gluxon commented 1 year ago

@ernestask Just a heads up that I force pushed a few changes to this branch.

gluxon commented 1 year ago

Going to merge this now and do more extensive testing on the ack message changes (https://github.com/gluxon/wireguard-uapi-rs/pull/21#discussion_r956978327) post-merge.