glwagner / OceanTurb.jl

Models and parameterizations for the turbulent ocean surface boundary layer in Julia
https://glwagner.github.io/OceanTurb.jl/latest/
MIT License
25 stars 7 forks source link

Require explicit 'grid' argument #76

Closed glwagner closed 4 years ago

glwagner commented 4 years ago

It will be trivial to implement stretched grids, so this could be implemented at any time. To prepare for this I think all models should require the argument grid, rather than accepting N and L. Making this change will also allow us to change the semantics of grid construction more readily.

sandreza commented 4 years ago

Thinking towards the future, it may be a good idea to think of the grid in the context of what is necessary for a Discontinuous Galerkin implementation of OceanTurb. For example, the notion of a grid topology can be separated from the nodal points that the solution exists.