search

glwagner / dedaLES

Large Eddy Simulation with dedalus
https://dedales.readthedocs.io
GNU General Public License v3.0
33 stars 11 forks source link

New names for subgrid scale contributions to momentum and tracer equations #13

Closed glwagner closed 5 years ago

glwagner commented 5 years ago

This pull request changes the name of subgrid scale stress divergence from Fx_sgs (etc) to 

Nu_sgs
Nv_sgs
Nw_sgs

for momentum, and Nc_sgs for a tracer c.

It also adds linear subgrid scale terms with names Lu_sgs, etc, which are added to the right side of a dedalus equation. This permits defining eddy viscosity closures with constant viscosity tensors and eddy diffusivity closures with constant diffusivity tensors (note that 'constant' can be exchanged with 'prescribed non-constant', where non-constant coefficients are permitted on the right-side of dedalus equations).

There are also some miscellaneous commits associated with minor development.

glwagner commented 5 years ago

@SandreOuza, why don't you look at my implementation in closures.py and let me know what you think?