glycojones
commented
3 weeks ago HI Jordan, Could you help me test all this on Monday please? Cheers, Jon
On Sat, 15 Jun 2024 at 09:54, Jordan Dialpuri @.***> wrote:
What's Changed
- Updated to gemmi 0.6.5 from 0.5.8
- Added temporary fix for Firefox
- Updated clipper-gemmi version
- Moved from sajson to simdjson
Testing
This is a large pull request which changes a lot of the backend, the following must be tested on Chrome and Firefox at the minimum but also Safari preferably.
- Search a CIF only (7nyd) file - should work on Chrome and fail on Firefox
- Search a PDB file (5fji) - should work on both
- Upload any file - should work on both
- Quick tests on database and stats page
You can view, comment on, or merge this pull request online at:
https://github.com/glycojones/privateer/pull/100 Commit Summary
- 6b9c534 https://github.com/glycojones/privateer/pull/100/commits/6b9c5348f3dcee99be004b592fe912ec397da605 Updated gemmi and clipper-gemmi versions
- 0e77a08 https://github.com/glycojones/privateer/pull/100/commits/0e77a08f3d419a729bb2844969d77cb6199c7d30 Added gemmi CMakeLists.txt
File Changes
(15 files https://github.com/glycojones/privateer/pull/100/files)
- M CMakeLists.txt https://github.com/glycojones/privateer/pull/100/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a (11)
- M build.sh https://github.com/glycojones/privateer/pull/100/files#diff-4d2a8eefdf2a9783512a35da4dc7676a66404b6f3826a8af9aad038722da6823 (8)
- M clipper/gemmi/CMakeLists.txt https://github.com/glycojones/privateer/pull/100/files#diff-2d227e69b557dabfe41bc1bb6f5c46231aa97c3067a6158f1298a99bc820e4a0 (18)
- M clipper/minimol/CMakeLists.txt https://github.com/glycojones/privateer/pull/100/files#diff-7ec3bf92ef19e5a222b8e880b4b207e33735d9806385bde9d7e72ee33700a713 (19)
- A gemmi/CMakeLists.txt https://github.com/glycojones/privateer/pull/100/files#diff-192ea9de23a1d1ab99bff01bcfb0f8edbb405b89f2a95a5ddb24ee7ae4b6c29b (324)
- M src/privateer/cpp/clipper-glyco.h https://github.com/glycojones/privateer/pull/100/files#diff-22818d2d145a918e0d1f6ff8de1b41601d50ffb2f4d1be52ac4e702f74b9edea (2)
- M src/privateer/cpp/privateer-bind.cpp https://github.com/glycojones/privateer/pull/100/files#diff-3632186bd0346d35d62809d5a39d89c63c01c111fc16f411cd0055454d06cbe6 (7)
- M src/privateer/cpp/privateer-interactions.cpp https://github.com/glycojones/privateer/pull/100/files#diff-9b250e195e4a2018a2699db178ed4aa1ae6d7fa7ca1120a859c3fc513c744186 (140)
- M src/privateer/cpp/privateer-interactions.h https://github.com/glycojones/privateer/pull/100/files#diff-3313e5664e3f98f2e12969312c5062e0e88f8adf0121cda5738a97df5af69a2f (2)
- M src/privateer/cpp/privateer-json.h https://github.com/glycojones/privateer/pull/100/files#diff-a5ebd218aef6d7c6440df959c223ac2fbd57e01b9e5fdc777159a5a0fb53846e (623)
- M src/privateer/cpp/third-party/gemmi_compilation_unit.cpp https://github.com/glycojones/privateer/pull/100/files#diff-9285006eb01d16fa10cd502053a994b5bd49ae3a14e17f1c746c7b1edd690ea0 (26)
- A src/privateer/cpp/third-party/simdjson/simdjson.cpp https://github.com/glycojones/privateer/pull/100/files#diff-af5332745728a8fad8f2a4cccd478033f2e5df783bcb0e3a6ca8b1db634e367a (43387)
- A src/privateer/cpp/third-party/simdjson/simdjson.h https://github.com/glycojones/privateer/pull/100/files#diff-cfb316f69a9f29b8950ff844d94b08eb32011315ec238c5b94d2c620830731fb (88545)
- M webapp/src/wasm/privateer.js https://github.com/glycojones/privateer/pull/100/files#diff-30e371869c5f60754ec5d921bde70f5f001176e6a0bd1635ba44feebb04a80be (2)
- M webapp/src/wasm/privateer.wasm https://github.com/glycojones/privateer/pull/100/files#diff-c4e6f830004069f96a27298044fd073d4d0db77ce4b23c3f6c16351451d49fc8 (0)
Patch Links:
- https://github.com/glycojones/privateer/pull/100.patch
- https://github.com/glycojones/privateer/pull/100.diff
— Reply to this email directly, view it on GitHub https://github.com/glycojones/privateer/pull/100, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIHCVHHY772352SYVNXN5TZHP6LDAVCNFSM6AAAAABJLQWGASVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2TINRXGE4DSNQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
-- Dr Jon Agirre (he/him/his) Royal Society University Research Fellow at YSBL, Dept of Chemistry, University of York, UK Main editor at Acta F: Structural Biology Communications – watch our Interviews With Authors https://youtube.com/playlist?list=PL6UK2yPUlpxqkSpHBXd6hs6eipOFx87QI&feature=shared !
What's Changed
Testing
This is a large pull request which changes a lot of the backend, the following must be tested on Chrome and Firefox at the minimum but also Safari preferably.