search

glycojones / privateer

The Swiss Army knife for carbohydrate structure validation, refinement and analysis
GNU Lesser General Public License v2.1
26 stars 9 forks source link

Add residue metadata to SVG tags #54

Closed GABRAH closed 11 months ago

GABRAH commented 11 months ago

This pull request addresses the following issue: https://github.com/glycojones/privateer/issues/40

Unfortunately I was not able to integrate these changes with the frontend as I was unable to install privateer_wasm, need individual help with that one.

Anyway, the residue metadata in SVG tags should appear like this: Normal glycans(points both to amino acid and individual sugars): image Ligands(notice how the metadata is pointing to the first sugar rather than amino acid): image

I think the residue metadata in the following format chainID="f" resname="NAG" seqnum="1" should be enough to build a query parameter in Moorhen.

Please let me know if you'd like anything adjusted or if this does not work at all :D

Dialpuri commented 11 months ago

Looks good, I will test it out properly tomorrow 😀

GABRAH commented 11 months ago

Apologies for causing merge conflicts. I messed up by creating this new branch from main, rather than webserver. I thought that GitHub would be smart enough to not attempt overwrite webserver specific files with versions from main, but that appears to not be the case.

When merging these changes, attention needs to be paid to:

.gitignore CMakeLists.txt

After the merge is complete, this branch can be deleted.