glygener / glygen-issues

Repository for public GlyGen tickets
GNU General Public License v3.0
0 stars 0 forks source link

Duplicate expression entries on glycan page #1269

Open kmartinez834 opened 1 week ago

kmartinez834 commented 1 week ago

All of the P07288-1 Asn69 rows appear to be identical: https://www.glygen.org/glycan/G59655SA#Expression image

However, the API includes abundance information, so these are separate objects. Add abundance to glycan details page or remove redundant rows from expression section?

"expression": [
    {
      "category": "tissue",
      "tissue": {
        "name": "seminal fluid",
        "namespace": "UBERON",
        "id": "0006530",
        "url": "http://purl.obolibrary.org/obo/UBERON_0006530"
      },
      "abundance": "15.36%",
      "evidence": [
        {
          "id": "33167210",
          "database": "PubMed",
          "url": "https://glygen.org/publication/PubMed/33167210"
        },
        {
          "id": "10.1016/j.talanta.2020.121495",
          "database": "DOI",
          "url": "https://glygen.org/publication/DOI/10.1016/j.talanta.2020.121495"
        }
      ],
      "start_pos": 69,
      "end_pos": 69,
      "residue": "Asn",
      "uniprot_canonical_ac": "P07288-1"
    },
    {
      "category": "tissue",
      "tissue": {
        "name": "seminal fluid",
        "namespace": "UBERON",
        "id": "0006530",
        "url": "http://purl.obolibrary.org/obo/UBERON_0006530"
      },
      "abundance": "17.01%",
      "evidence": [
        {
          "id": "33167210",
          "database": "PubMed",
          "url": "https://glygen.org/publication/PubMed/33167210"
        },
        {
          "id": "10.1016/j.talanta.2020.121495",
          "database": "DOI",
          "url": "https://glygen.org/publication/DOI/10.1016/j.talanta.2020.121495"
        }
      ],
      "start_pos": 69,
      "end_pos": 69,
      "residue": "Asn",
      "uniprot_canonical_ac": "P07288-1"
    },
kmartinez834 commented 1 week ago

We discussed during the General meeting today. We want to add a column to the Glycan details expression section with an icon that enables user to select publication with abundance info.

Need to decide if this will be implemented by front end or back end.

ReneRanzinger commented 1 week ago

@sujeetvkulkarni Is this information client or server side paginated?

sujeetvkulkarni commented 1 week ago

@ReneRanzinger Both expression table entries (tissue and cell line) are server side paginated.

ReneRanzinger commented 1 week ago

In that case the duplication needs to happen server side. To be able to make the icon we will have to add new properties in the JSON:

sujeetvkulkarni commented 1 week ago

@ReneRanzinger @rykahsay A property with paper list, having evidence data will be good. As we can display list of paper ids (with links to publication details page) in the Abundance column. Array can be empty if there is no abundance data.

abundance: [
       {
          "id": "33167210",
          "database": "PubMed",
          "url": "https://glygen.org/publication/PubMed/33167210"
        },
        {
          "id": "10.1016/j.talanta.2020.121495",
          "database": "DOI",
          "url": "https://glygen.org/publication/DOI/10.1016/j.talanta.2020.121495"
        }
      ]
rykahsay commented 1 week ago

Am I missing something? Why a simple addition of "abundance" column to the table in the frontend cannot address this? Why do we need to change the data model?