glygener / glygen-issues

Repository for public GlyGen tickets
GNU General Public License v3.0
0 stars 0 forks source link

Evaluate the integration of Wenjins composition search and topology display #1420

Open ReneRanzinger opened 1 year ago

ReneRanzinger commented 1 year ago

NIce to see you in person on the F2F in last month.

We recently changed the GNOme viewer in the past weeks which support base composition monosaccharides.

Please feel free to play around, and any suggestions would be appreciated!

https://raw.githack.com/glygen-glycan-data/GNOme/master/GNOme.browser.myopic.html

Do you think it is helpful that GlyGen pages integrated this viewer?

If it is, we probably need to discuss about how GlyGen pages interact with viewer by JavaScript and other stuff to make it useful.

Please let us know what you think.

Thank you!

Best,

Wenjin

ReneRanzinger commented 1 year ago

Hi Wenjin,

thank you for sharing the code and the example. I had a look at it and saw a few things: • The hint says that I can use keyboard shortcuts for monosaccharides but It does not say what these keys are • It also says I can mouse over the MS to get more details but this does not work on Firefox or Chrome • I like the right click context menu but when I mouse over the menu entries I get a text cursor rather than the standard mouse cursor or the link cursor. That is confusing. • There is several times the reference to “upper panel” and “lower panel”. That is confusing since they are displayed in “individual pages” rather than above and below each other.

The integration of your tools is on the tasklist for 1.6+. Simply because I am not sure they actually have the subsumption data in glygen yet. A few concerns regarding compatibility: • The ID of the div is hardcoded in your JS code. I am telling my students here, that each widget should be dynamic and the ID of the div should be passed to the JS code. Of course a binding as with react is an alternative. • How flexible is your code with regards to size changes of the div? It looks fine for an 1920*1080 resolution, but if I decrease the window size immediately a scrollbar is poping up for the window (not the div). I think it would be nice if the structures and view would dynamically arrange based on the available space (as long as the width stays above a certain minimum).

Let me know what you think, René