glygener / glygen-issues

Repository for public GlyGen tickets
GNU General Public License v3.0
0 stars 0 forks source link

Biomarker component issue #1492

Closed DaniallMasood closed 1 day ago

DaniallMasood commented 2 months ago

@sujeetvkulkarni In the component section for a lot of biomarkers there is no component being shown even though it has components and information in there. It seems that it is using the GlyGen structure still of it being either protein or a glycan. We have different types of biomarkers and their components are not being shown (example below) is there a way to fix that? What has to be done?

The information can just be put out into a table and not have the tabs of "glycan" or "protein" or any other entity

@seankim658

Image

sujeetvkulkarni commented 2 months ago

@DaniallMasood It can be shown. We just have to come up with a strategy - All in one table with type property or different tabs etc.

DaniallMasood commented 2 months ago

@sujeetvkulkarni i think table with type property would be best since we have so many different types of biomarkers.

eventually panel biomarkers will have components of different entity types so this would be best.

sujeetvkulkarni commented 2 months ago

@DaniallMasood Ok, then we will need to have 8 columns including Type. Glycan Image will remain empty in other cases and LOINC Code will remain empty in Glycan case.

https://www.glygen.org/biomarker/AA5041-1#Components

Screenshot 2024-07-02 at 12 25 43 PM

https://www.glygen.org/biomarker/AA4761-1#Components

Screenshot 2024-07-02 at 12 26 08 PM

DaniallMasood commented 2 months ago

@sujeetvkulkarni maybe there is some misunderstanding but I was thinking just displaying the table withoout the tabs above. Just display the data from the json and have it like the second screenshot with the assessed_entity_type present as well where it would indicate if it is a protein,glycan, gene, etc

sujeetvkulkarni commented 2 months ago

@DaniallMasood I showed current columns in the screen shots and proposed a single table with 8 columns. I think you are proposing 7 columns and dont want Glycan Image in it.

DaniallMasood commented 2 months ago

@sujeetvkulkarni yes but we can keep 8 columns and just add in the information of assessed_entity_type which is in the json, instead of having glycan image if possible

sujeetvkulkarni commented 2 months ago

@DaniallMasood ok, I will add assessed_entity_type and remove Glycan Image in a single table. Total 7 columns.

DaniallMasood commented 2 months ago

@sujeetvkulkarni oh yes that is my fault. I was not counting correctly and missed that. Thank you and sounds good to me

DaniallMasood commented 2 months ago

@sujeetvkulkarni when do you think this change will be done by? Is it possible to be completed this week

sujeetvkulkarni commented 2 months ago

@DaniallMasood yes, I will do it and let you know.

sujeetvkulkarni commented 2 months ago

@DaniallMasood I have made the change. https://glygen.ccrc.uga.edu/frontend/biomarker/AA4686-16 Please have a look.