glygener / glygen-issues

Repository for public GlyGen tickets
GNU General Public License v3.0
0 stars 0 forks source link

Review GAG classifiers #602

Closed ReneRanzinger closed 1 day ago

ReneRanzinger commented 1 year ago

At some point we will have to review the GAG classifiers. I see two tasks there:

edwardsnj commented 10 months ago

@ReneRanzinger Second point - I don't understand - it appears to match correctly at the core. I'm wondering if there used to be an old (bad) image for that accession and now it is correct with a 2S on the monosaccharide at the reducing end?

First point - I agree it would be nice. I implemented Keratan sulfate as a GAG subtype but for the rest I couldn't pin down a definition. Just the core motif matching was not enough for the Keratan sulfate subclass, there were a bunch of additional heuristics needed. Similar heuristics could be defined for the other specific GAGs.

ReneRanzinger commented 10 months ago

@edwardsnj I dont see the second problem anymore. Either it was one of the tickets I made late at night and I was too tired and was not thinking clearly ... or it was an old image issue.