search

glyph / DBXS

Database Access
Other
17 stars 0 forks source link

much better error reporting on arity mismatches in loaders #84

Closed glyph closed 7 months ago

glyph commented 7 months ago

The tracebacks when accidentally getting the signature wrong on a one() or many() loader were sufficiently difficult to debug that I really wanted to make it quickly possible to debug where the relevant loader was actually defined. This adds some synthetic traceback lines which make it much easier to see.

This commit was sponsored by rockstar, Jason Walker, Steven S., and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.40%. Comparing base (2152e7b) to head (50f16a1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #84 +/- ## =========================================== - Coverage 99.91% 84.40% -15.51% =========================================== Files 17 17 Lines 1181 1257 +76 Branches 174 182 +8 =========================================== - Hits 1180 1061 -119 - Misses 1 192 +191 - Partials 0 4 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.