Add support for Python 3.7+

glyph / DateType

A type wrapper for the standard library `datetime` that supplies stricter checks, such as making 'datetime' not substitutable for 'date', and separating out Naive and Aware datetimes into separate, mutually-incompatible types.

Other

73 stars 6 forks source link

Add support for Python 3.7+ #7

Closed m-aciek closed 7 months ago

m-aciek commented 1 year ago

Uses typing syntax compatible with Python 3.7.
Adapts the protocols definitions for earlier Python versions.
Starts to test in CI Python versions from 3.7 to 3.12.
Extends the test to support partial functionality for Python 3.7. I wasn't able to make NaiveDateTime/AwareDateTime work properly for Python 3.7 due to interface incompatibilities. Only Date/DateTime is supported as expected for Python 3.7. Full functionality for Python 3.8+.

Closes #6.

m-aciek commented 7 months ago

@glyph would it be possible for you to take some time to review the PR?

glyph commented 7 months ago

@m-aciek Sure, I'll have a look. Per https://endoflife.date/python, 3.7 is unsupported, but given that this is a load-bearing piece of infrastructure it seems worthwhile to have a bit of extra long-tail support. Plus, I did say I'd look at your PR :).

I'll do a release, but you should expect 3.7 support to be fairly short-lived.

glyph commented 7 months ago

@m-aciek This is included in a new release here: https://pypi.org/project/datetype/2024.2.8/

m-aciek commented 7 months ago

Thank you very much!

glyph commented 7 months ago

You're welcome! Thanks for your contribution.