Open damaestro opened 21 hours ago
The docs are attempting to build their own viewsource URL that corresponds to the place that the code is coming from. It seems to me that the right way to do this for a source checkout is to interrogate the version that the source claims to be respresenting, then compute a viewsource URL derived from the named tag it should correspond to.
Alternately, move all git
command executions onto the path where they will actually be used, i.e. ensure that we do not invoke them at all on the READTHEDOCS_VERSION
code path, then builders can use that?
I am open to other suggestions.
An option to be able to pass in the tag/version would also be fine. That's basically what I've done manually in a downstream patch. If we could just pass the package version to the sphinx-build
command and then the git
commands are not attempted that would work.
When downloading a repo archive or the source from PyPI, the docs wont build due to not being able to run git commands.