search

glyph / python-docstring-mode

Emacs minor-mode for editing Python docstrings.
MIT License
70 stars 22 forks source link

Sort of port to Python 3 #12

Closed hynek closed 8 years ago

hynek commented 8 years ago

So this is more of a WIP or a inspiration for you. I’ve fixed the obvious problems but two things popped up:

  1. In Python 3, it adds extra empty empty lines after each paragraph. I tried to debug it but that’s some serious OOP pasta right there. :)
  2. Sphinx formatting is broken in both cases. The test case is marked as expected failure.
glyph commented 8 years ago

Adding test cases is HUGELY welcome. Sorry it took so long for me to look at this, I'm still trying to get a personal workflow that involves actually reviewing miscellaneous projects on github. Would you do me the kindness of updating the code?

glyph commented 8 years ago

And by "updating the code" I mean "merging master or vice versa".

glyph commented 8 years ago

(This looks like something I definitely want to merge, having some test cases here would be fantastic.)

hynek commented 8 years ago

done

glyph commented 8 years ago

yay, some CI

hynek commented 8 years ago

Well it’s failing for Python 3 tho. :)

Since the other PR kind of fixed the need for Python 3 compatibility, I guess you can just reduce the CI to Python 2 for now?

glyph commented 8 years ago

Already done, in #15 .