search

glyph / python-docstring-mode

Emacs minor-mode for editing Python docstrings.
MIT License
70 stars 22 forks source link

Add support for using single space between sentences #21

Closed selmanj closed 7 years ago

selmanj commented 7 years ago

python-docstring.el will respect the value of sentence-end-double-space.

glyph commented 7 years ago

Thanks very much for your contribution!

I have slightly mixed feelings about this; on the one hand, sentence-end-double-space is an established way of configuring this behavior, and people's opinions on how it should work differ. On the other, one of the major motivations for this mode to exist is to avoid projects having diff noise when people have different configurations for re-wrapping docstrings.

If someone configured sentence-end-double-space in custom because they just happened to prefer the aesthetics, it would mean they'd be mangling docstring sentence-ends in any shared project they were to touch.

I'm not sure what the right solution is here; perhaps a separate, explicit python-docstring-honor-sentence-end-double-space that defaults to nil?

selmanj commented 7 years ago

That makes sense. I'll add a customize option that lets you use single spacing (defaulting to double space).

selmanj commented 7 years ago

This is ready for review.

glyph commented 7 years ago

I've sat on this long enough :) thank you for your contribution.